[doc] Fix ambiguous signoff template#604
Open
martin-velay wants to merge 1 commit into
Open
Conversation
martin-velay
force-pushed
the
fix_signoff_template
branch
2 times, most recently
from
2f12313 to
a5e08a4
Compare
Collaborator
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Thanks for this, just a few more comments that would be useful and then I think this is a good change.
Signed-off-by: martin-velay <mvelay@lowrisc.org>
martin-velay
force-pushed
the
fix_signoff_template
branch
from
a5e08a4 to
3a1917e
Compare
Contributor
Author
|
Thanks for your review @marnovandermaas, I think all your comments are now addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here #573 (comment)