[xbar_peri,dv] V1 sign-off checklist#573
Open
martin-velay wants to merge 1 commit into
Open
Conversation
martin-velay
force-pushed
the
xbar_peri_v1_signoff
branch
2 times, most recently
from
e41b6d7 to
2433aa6
Compare
martin-velay
force-pushed
the
xbar_peri_v1_signoff
branch
2 times, most recently
from
496d0bb to
3cf55e3
Compare
Collaborator
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Thanks this is great work! I just had a few minor comments.
|
|
||
| ### V1 | ||
|
|
||
| <!-- Git hash: d051a93 (nightly 2026-05-20) --> |
Collaborator
There was a problem hiding this comment.
We shouldn't put this in a comment, rather put this in the text and add links.
Contributor
Author
There was a problem hiding this comment.
I have been confused by the template. Shall we update it too?
Collaborator
There was a problem hiding this comment.
Yes, probably makes sense to update the template too.
| | Documentation | TESTPLAN_COMPLETED | Done | [TLUL testplan][] | | ||
| | Testbench | TB_TOP_CREATED | Done | DUT instantiated in `hw/top_chip/ip/xbar_peri/dv/autogen/tb__xbar_connect.sv` with all 12 TL interfaces connected | | ||
| | Testbench | PRELIMINARY_ASSERTION_CHECKS_ADDED | Done | <ul><li>X/unknown checks on TL channel signals provided in `tlul_assert.sv`</li><li>TLUL protocol assertions bound in `xbar_peri_bind.sv` for all interfaces</li></ul> | | ||
| | Integration | PRE_VERIFIED_SUB_MODULES_V1 | Waived | TLUL socket primitives (`tlul_socket_1n`, `tlul_socket_m1`) sourced from `lowrisc_ip` vendor library, carried as pre-verified at V2 in OpenTitan per `hw/ip/tlul/data/tlul.prj.hjson`; `prim_arbiter` waived, consistent with OpenTitan V1 precedent | |
Collaborator
There was a problem hiding this comment.
Can we link the pull request in which these were originally signed off?
Signed-off-by: martin-velay <mvelay@lowrisc.org>
martin-velay
force-pushed
the
xbar_peri_v1_signoff
branch
from
3cf55e3 to
68f4395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V1 sign-off for XBAR_PERI. This pull request should have three approvers before merging.
Closes: #159