Skip to content

Remove getModelStatus extra arg #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
facundosw wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove getModelStatus extra arg #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8033c33
remove extra arg
CacheFail Dec 20, 2024
d918969
add test and large model
CacheFail Dec 20, 2024
22d09a1
Merge remote-tracking branch 'origin/main' into fix-getModelStatus-args
CacheFail Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const MODEL_STATUS_CODES = /** @type {const} */ ({
var /** @type {()=>Highs} */ _Highs_create,
/** @type {(arg0:Highs)=>void} */ _Highs_run,
/** @type {(arg0:Highs)=>void} */ _Highs_destroy,
/** @type {(arg0:Highs, arg1:number)=>(keyof (typeof MODEL_STATUS_CODES))} */ _Highs_getModelStatus,
/** @type {(arg0:Highs)=>(keyof (typeof MODEL_STATUS_CODES))} */ _Highs_getModelStatus,
/** @type {any}*/ FS;

/**
Expand Down Expand Up @@ -89,7 +89,7 @@ Module["solve"] = function (model_str, highs_options) {
}
assert_ok(() => _Highs_run(highs), "solve the problem");
const status =
MODEL_STATUS_CODES[_Highs_getModelStatus(highs, 0)] || "Unknown";
MODEL_STATUS_CODES[_Highs_getModelStatus(highs)] || "Unknown";
// Flush the content of stdout in order to have a clean stream before writing the solution in it
stdout_lines.length = 0;
assert_ok(
Expand Down
Loading