Skip to content

Fix incorrect y-axis scaling #124

Open
gohar94 wants to merge 1 commit into
louwrentius:masterfrom
gohar94:master
Open

Fix incorrect y-axis scaling #124
gohar94 wants to merge 1 commit into
louwrentius:masterfrom
gohar94:master

Conversation

@gohar94

@gohar94 gohar94 commented Aug 3, 2023

Copy link
Copy Markdown

When plotting read and writes together as a line graph, the y-axis scale is incorrect.
Following commands can be used to reproduce this:

Incorrect:

fio-plot -i Foo -T "Bug" -g -t lat -n 1 -d 16 -r randrw --xlabel-parent 0 --filter write read

Correct:

fio-plot -i Foo -T "Bug" -g -t lat -n 1 -d 16 -r randrw --xlabel-parent 0 --filter write
fio-plot -i Foo -T "Bug" -g -t lat -n 1 -d 16 -r randrw --xlabel-parent 0 --filter read

When plotting reads and writes separately, the output is correct. When plotting them together, the y-axis scale is incorrect.

@louwrentius

Copy link
Copy Markdown
Owner

Thanks for reporting the issue and providing a fix!
I'll test and deploy an updated version in the coming days.

@louwrentius

Copy link
Copy Markdown
Owner

@gohar94 I made a clone of your repo and used some test data and I think it's still broken. My data contains write data that individually scales to microseconds(us) and read data that scales to milliseconds.

I still get buggy graphs like this:
Bug_2023-08-04_160951_xS

I'll have to investigate this issue further. When both read/write data is graphed, the code has to settle on one scale and scale both read and write data accordingly, which doesn't seem to happen I guess.

@triii10

triii10 commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

The fix for scaling the y-axis should be a simple fix. Created this pull request #148 with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants