fix: keep physical local playback outside Gelato probes#190
Open
ChosenQuill wants to merge 1 commit into
Open
Conversation
ChosenQuill
force-pushed
the
agent/local-playback-probe-boundary
branch
from
July 26, 2026 09:08
d66f31d to
2e4412e
Compare
There was a problem hiding this comment.
Pull request overview
Adjusts Gelato playback ownership detection so that Stremio provider IDs remain metadata-only and no longer force physical local media sources through Gelato’s probing/playback path. This aligns playback routing with the intended semantics of mixed libraries and prevents local filesystem sources from being treated as Gelato-owned after SyncStreams.
Changes:
- Replace provider-ID-based ownership checks with playback-specific ownership (
gelato-streamtag orgelato://path). - Delegate playback back to Jellyfin when the selected media source resolves to a non-Gelato playback owner.
- Centralize the new ownership rule in
IsGelatoPlaybackItem(...)and apply it in both static and playback media source flows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #189.
SyncStreamscopies theStremioprovider ID to a primary local item. Playback then usesIsGelato(), which treats that metadata ID as Gelato playback ownership and can send the physical local source through Gelato's probe path.This change keeps the existing metadata behavior but uses playback-specific ownership:
gelato-streamtag.gelato://path.No Gelato stream protocol, probing, stubbing, user resolution, or CI behavior is changed.
Validation
dotnet build Gelato.sln --configuration Release: succeeded with 0 errors.dotnet format Gelato.sln --verify-no-changes --no-restore: clean.2e4412e) was built and deployed on Jellyfin 10.11.11. The reproduced physical local title returned one nativeFilesource (IsRemote=false, no stub); its HLS playlist and segment returned HTTP 200, and Jellyfin Web playback advanced.