Allow trailing spaces in HTTP_X_FORWARDED_FOR (eg NetScaler MPX-15000)#9
Open
timbunce wants to merge 1 commit into
Open
Allow trailing spaces in HTTP_X_FORWARDED_FOR (eg NetScaler MPX-15000)#9timbunce wants to merge 1 commit into
timbunce wants to merge 1 commit into
Conversation
We're using a NetScaler MPX-15000 (running NS9.3: Build 59.5.nc) and it's adding trailing spaces into the X-Forwarded-For header. This change allows trailing spaces to be ignored. (It also prevents REMOTE_ADDR from being set to undef if the HTTP_X_FORWARDED_FOR parsing fails. That seems like a good idea, but isn't an important change for me.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using a NetScaler MPX-15000 (running NS9.3: Build 59.5.nc)
and it's adding trailing spaces into the X-Forwarded-For header.
This change allows trailing spaces to be ignored.
(It also prevents REMOTE_ADDR from being set to undef if the
HTTP_X_FORWARDED_FOR parsing fails. That seems like a good idea, but
isn't an important change for me.)