Skip to content

Renamed Hal to HAL to comply with general naming scheme and to make i…#16

Open
Laplace-Transformer wants to merge 1 commit into
looxonline:BIQUBX_ALMOST_STOCKfrom
Laplace-Transformer:casesensitive_paths
Open

Renamed Hal to HAL to comply with general naming scheme and to make i…#16
Laplace-Transformer wants to merge 1 commit into
looxonline:BIQUBX_ALMOST_STOCKfrom
Laplace-Transformer:casesensitive_paths

Conversation

@Laplace-Transformer

@Laplace-Transformer Laplace-Transformer commented Sep 5, 2021

Copy link
Copy Markdown

Compilable on clean Linux on VS Code with Auto Marlin Builder

Requirements

None that wasn't previous in the build.
VS Code + PlatformIO/Auto Marlin Builder

Description

Benefits

Configurations

Related Issues

@ellisgl

ellisgl commented Sep 5, 2021

Copy link
Copy Markdown

Standard naming conventions, are you nuts? LOL

@Laplace-Transformer

Copy link
Copy Markdown
Author

Thank you for your comment. If you have an issue with the PR or a constructive criticism please post it.
I've made this PR as Luke's build didn't currently work on Unix based systems without macros to ignore path case sensitivity. Either I should update HAL to Hal in some of the files or I could rename the folder to HAL (like it is done in base Marlin) and change some of the files as well.

I'm just trying to help.

@ellisgl

ellisgl commented Sep 7, 2021

Copy link
Copy Markdown

@Laplace-Transformer I was trying to funny. I very much welcome changes that get things into standards that are set in place and appreciate what you have done. In my programming job, it's hard thing to do to go back and fix when it's out in the wild.

@ellisgl

ellisgl commented Dec 30, 2022

Copy link
Copy Markdown

@looxonline any plans on merging this in? Also updating the base marlin stuff?

@looxonline

Copy link
Copy Markdown
Owner

@looxonline any plans on merging this in? Also updating the base marlin stuff?

Updating the base Marlin is not feasible while retaining the BTT UI. I am going to look at updating the base while also retaining the ability to switch between the BTT UI and the SBC UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants