Bind in register - #537
Merged
Merged
Conversation
yaauie
commented
Apr 16, 2026
7 tasks
andrewvc
previously requested changes
Apr 17, 2026
5 tasks
Co-authored-by: Andrew Cholakian <andrew@andrewvc.com> Co-authored-by: Rye Biesemeyer <yaauie@users.noreply.github.com>
donoghuc
requested changes
Jul 2, 2026
donoghuc
left a comment
donoghuc
left a comment
Contributor
There was a problem hiding this comment.
Couple small parity things with http. Otherwise looks good!
Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com> Co-authored-by: Rye Biesemeyer <yaauie@users.noreply.github.com>
donoghuc
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pr is best reviewed commit-by-commit. Each commit passes tests with
ELASTIC_STACK_VERSION=9.current, which currently resolves to 9.3.3.Moves the binding of the port into
#register(with the listening channel's auto-read disabled), and then activates the auto-read in#runafter theMessageListenerwith access to the queue is available.Note: migrates from a blocking
Server#listentoServer#run(MessageListener)in order to remain descriptive.Meta: elastic/logstash#18711