Updated to Timber.Tree#3
Open
varshneyjayant wants to merge 2 commits into
Open
Conversation
varshneyjayant
commented
Aug 12, 2015
varshneyjayant
commented
- Timber.HollowTree was deprecated
- Added support for Appname
1. Timber.HollowTree was deprecated 2. Added support for Appname
There was a problem hiding this comment.
@psquickitjayant why change from Level to int?
Author
There was a problem hiding this comment.
@mostlyjason the new library Timber.Tree takes int as parameter
Author
|
@tony19 We have improved the usage of |
Author
|
Removed extra code for |
Author
|
Do you want a separate PR as feature update for |
Author
|
updated comments. |
| @@ -52,6 +53,43 @@ public LogglyTree(String token) { | |||
| // TODO: handle failed messages with N retries | |||
| handler = new LogglyClient.Callback() { | |||
| @Override | |||
|
What do we need to do to get a new version of Timber supported? I can take over this PR if necessary. |
Author
|
@darren-kelinske-fivestars Please go ahead and raise a PR. Also, please directly contact the loggly github page. Thanks, Jayant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.