[WIP] V1.4.x.shopinvader Geoip - #132
Open
sylvainc wants to merge 21 commits into
Open
Conversation
…fy the code. Smtp key are now hardcoded, only stmp namespace is customizable
…o display the index page in the default locale by calling path_to
… in order to avoid conflicts
…header with all the params
…tead of the session, so you can cache it easier with external proxy
…the service registred already have keep in memory the information of the person logged. By doing a redirect we are sure to build a page without information that depend of the current sign out user
V1.4.x.shopinvader cookie backport
…his raise an issue when injecting cookie. As cookies are not needed for robots.txt we do not pass them
[FIX] solve issue on robot.txt page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This patch is a proof of concept (DO NOT MERGE IT!), major refactors/improvements needed (l have a limited knowledge in Ruby/Rails/Steam) but it seems to works!
The goal is to create a new liquid variable called country which as its name indicates allows to determine from which country the query comes from, which is very useful in multi-lingual/multi-country sites.
Technically the language is detected by the using a GeoIP database (Maxmind) which allows from the IP address of the visitor to determine the country.
As this search is expensive we use a specific cookie to store this information in the next queries, and a country parameter in the URL allows to modify this cookie and thus the current country of the user.
I'will try to improve this patch in the next days...
Regards