Fix AsCurrency, StringTableEntry#127
Merged
Merged
Conversation
scottanderson
force-pushed
the
string-table-entry
branch
from
5ea22db to
c4a2d79
Compare
scottanderson
changed the title
scottanderson
force-pushed
the
string-table-entry
branch
from
c4a2d79 to
d1ef522
Compare
Collaborator
Author
|
@localcc I resolved the conflict, mind taking a look? Thanks! |
localcc
approved these changes
May 3, 2025
Owner
|
Ah yeah, sorry for such a long delay on the review. Approved, but there seem to be conflicts which prevent rebasing, could you please resolve those? |
Collaborator
Author
|
@localcc no worries, thanks for the review. I think you're seeing that issue because I resolved the conflict with a merge, so you won't be able to rebase the change. You can still use the merge or squash and merge options, though. I personally prefer the squash and merge option in a situation like this one, where the repo is the primary upstream repo, but either one will work. |
Collaborator
Author
|
@localcc would you mind releasing a new version of the library with this fix? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug with the implementation of
AsCurrencyandStringTableEntryinFTextHistory.