[GG] fix(workspace): isolate target and speculative execution buffers - #151
[GG] fix(workspace): isolate target and speculative execution buffers#151voipmonitor wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Root cause
The target model and speculator previously shared process-global workspace storage. Captured views from one execution path could be invalidated or aliased when the other path resized or reused that storage. Workspace ownership must include both ubatch and execution lane.
Merge order
This branch is based directly on
dev/gilded-gnosis; it is not stacked. Merge this before the reduced #149. After it lands, #149 will be refreshed against the new GG head so its profiling-only speculator capture also enters lane 1.Validation
tests/v1/worker/test_workspace.py: 3 passedgit diff --checkpassed