Skip to content

[GG] fix(workspace): isolate target and speculative execution buffers - #151

Closed
voipmonitor wants to merge 1 commit into
dev/gilded-gnosisfrom
fix/gg-speculator-workspace-lanes-20260721
Closed

[GG] fix(workspace): isolate target and speculative execution buffers#151
voipmonitor wants to merge 1 commit into
dev/gilded-gnosisfrom
fix/gg-speculator-workspace-lanes-20260721

Conversation

@voipmonitor

Copy link
Copy Markdown

Summary

  • add independent workspace lanes per ubatch
  • route target execution through lane 0 and speculative execution through lane 1
  • cover model load, attention setup, warmup, capture, proposal, and capacity computation
  • keep PCIe lifecycle, MRV2 profiling, and MoE scheduling changes out of this PR

Root cause

The target model and speculator previously shared process-global workspace storage. Captured views from one execution path could be invalidated or aliased when the other path resized or reused that storage. Workspace ownership must include both ubatch and execution lane.

Merge order

This branch is based directly on dev/gilded-gnosis; it is not stacked. Merge this before the reduced #149. After it lands, #149 will be refreshed against the new GG head so its profiling-only speculator capture also enters lane 1.

Validation

  • tests/v1/worker/test_workspace.py: 3 passed
  • Ruff lint and format checks passed
  • git diff --check passed

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@voipmonitor, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ee58648-fa57-4761-bce0-51ca6324dd47

📥 Commits

Reviewing files that changed from the base of the PR and between 73e4a8c and b14c1dc.

📒 Files selected for processing (5)
  • tests/v1/worker/test_workspace.py
  • vllm/v1/worker/gpu/model_runner.py
  • vllm/v1/worker/gpu/warmup.py
  • vllm/v1/worker/gpu_worker.py
  • vllm/v1/worker/workspace.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/gg-speculator-workspace-lanes-20260721

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@voipmonitor

Copy link
Copy Markdown
Author

Folded unchanged into #149 as the first reviewable commit. #149 now carries workspace ownership, graph-channel ownership, and MRV2 profiling as one direct-GG lifecycle fix, so there is no hidden merge-order dependency. Closing this PR as superseded; no implementation or tests were dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant