fix(pcie): isolate CUDA graph channel lifecycle#59
Conversation
Bind recycled capture streams to independent channels and make disposable-channel rollback coordinated and fail-safe.
|
Warning Review limit reached
Next review available in: 34 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Manual fallback review completed because the automated review was rate-limited. The channel ownership, capture isolation, rollback ordering, and coordinated IPC teardown paths were inspected against the current master; no actionable defect was found. Focused result: 41 passed; Ruff clean. @coderabbitai review |
|
✅ Action performedReview finished.
|
Summary
Why
Target and speculative graph managers can reuse CUDA stream identities while retaining different live graph resources. Sharing or prematurely recycling a PCIe channel across those captures can leave stale IPC state or destroy a channel still owned by a replayable graph.
This PR contains only the PCIe lifecycle half of #58 and is based directly on
master.Validation
tests/comm/test_pcie_dcp_a2a.pytests/comm/test_pcie_oneshot.py