fix(pcie): isolate nested CUDA graph capture channels - #42
Merged
lukealonso merged 1 commit intoJul 19, 2026
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Walkthrough
ChangesPCIe capture channel reuse
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant PCIePool
participant ChannelFactory
Caller->>PCIePool: enter capture(stream)
PCIePool->>ChannelFactory: create or retrieve channel
PCIePool->>PCIePool: push channel onto capture stack
Caller->>PCIePool: for_stream()
PCIePool->>PCIePool: reuse top captured channel
PCIePool-->>Caller: return captured channel
Caller->>PCIePool: exit capture
PCIePool->>PCIePool: pop and validate channel
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
voipmonitor
force-pushed
the
fix/pcie-oneshot-nested-capture-channel-20260719
branch
from
July 19, 2026 16:04
21e508e to
2d710b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
A communication channel owns mutable signal counters and double-buffered IPC staging memory. The old nested-capture fallback selected the first existing channel because allocating during CUDA capture is illegal. Independent target and MTP graph managers could therefore capture one shared channel and replay it concurrently, corrupting its state.
The pools now maintain an enclosing capture-channel stack. A torch/Inductor-owned nested capture stream aliases only the channel selected by its own outer graph manager. Target and draft captures consequently remain isolated without adding a runtime copy or synchronization.
Validation
tests/distributed/test_pcie_oneshot.pyandtests/distributed/test_pcie_dcp_a2a.py: 32 passedgit diff --check: passedIntegration