fix(ci): a BREAKING CHANGE footer is a footer, not a substring - #862
Merged
Conversation
The first run this workflow ever did took the engine from 0.2.44 to 1.0.0, because the pull request that introduced it explained the rule in a bullet and the bash conditional matched 'BREAKING CHANGE:' anywhere in the body. The decision moves into bump_version.py with a self-test beside it - the regression is one of its twelve cases - and the footer is anchored to the start of a line, which is what Conventional Commits actually says. Restores the version to 0.2.45, the patch that PR should have been.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version workflow's first run took the engine from 0.2.44 to 1.0.0. The pull request that introduced it explained the rule in a bullet — the literal string was in the body — and the bash conditional matched it anywhere, footer or not.
bump_version.py --decide, with--self-testbeside it. The regression is one of its twelve cases, and the workflow runs the self-test before it trusts the answer.^BREAKING[ -]CHANGE:), which is what Conventional Commits actually specifies. A subject is breaking only viatype!:.Labelled
no-version-bumpso the workflow does not immediately re-bump 1.0.0 to 1.0.1 and undo the correction.