feat: add alternative get_cell_size() method#139
Open
alissa-huskey wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the PR, the code looks good to me. Would you mind fixing the failing checks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an additional method of determining cell size.
The
CSI 16 tescape code does not appear to be supported by my terminal (iTerm2), so I added aCSI 14 tquery (to get the dimensions of the screen in pixels) and calculated the cell size in combination withshutil.get_terminal_size().I also added a
query_tty()function to wrapcapture_terminal_response, and did a bit of (subjective) cleanup.