Skip to content

feat: add basic kitty protocol support#120

Open
NSPC911 wants to merge 1 commit into
lnqs:mainfrom
NSPC911-forks:hey-tell-your-kitty-i-said-pspspspsps
Open

feat: add basic kitty protocol support#120
NSPC911 wants to merge 1 commit into
lnqs:mainfrom
NSPC911-forks:hey-tell-your-kitty-i-said-pspspspsps

Conversation

@NSPC911

@NSPC911 NSPC911 commented May 29, 2026

Copy link
Copy Markdown

i forgot to pr this, but you can close this if you prefer only tgp to exist

@NSPC911 NSPC911 force-pushed the hey-tell-your-kitty-i-said-pspspspsps branch from 9359d5b to c975f39 Compare May 29, 2026 10:49
@lnqs

lnqs commented May 29, 2026

Copy link
Copy Markdown
Owner

Could you explain what this PR is for? It's a second TGP implementation, isn't it?

@NSPC911

NSPC911 commented May 29, 2026

Copy link
Copy Markdown
Author

Well yes, but not all terminals support TGP. Most support the basic Kitty Image implementation, but not TGP.

It would make sense to remove TGP and have just Kitty because Kitty has more terminals supported as compared to TGP, but it is up to you.

@lnqs

lnqs commented May 29, 2026

Copy link
Copy Markdown
Owner

The protocol Kitty uses to render images is called Terminal Graphics Protocol, regardless of using the unicode placeholders or not.
However, as TGP is the only protocol that works without major glitches due to the placeholders I don't think we should remove them. And maintaining a buggy and a more or less bug-free implementation of the same protocol doesn't seem right to me -- especially as won't be able to differentiate what terminals supports the placeholders.
I rather ask the terminal maintainers to implement the full spec instead of only parts of it.
Or, at some point, create some PRs against textual itself to make the hacks unnecessary this package implements that cause the issues and switch to TGP without placeholders then.

@NSPC911

NSPC911 commented May 29, 2026

Copy link
Copy Markdown
Author

I really hope Textual does something to make image support official, the hacks needed for image support are just insane.

I will be leaving this PR in case you have second thoughts.

@NSPC911 NSPC911 force-pushed the hey-tell-your-kitty-i-said-pspspspsps branch from c975f39 to 8cd1247 Compare May 31, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants