fix halfcell for transparency#101
Open
NSPC911 wants to merge 1 commit into
Open
Conversation
Owner
|
The code looks fine to me. Would you mind rebasing the PR and adding tests for the missing lines? |
NSPC911
force-pushed
the
transparent-halfcell
branch
2 times, most recently
from
f280090 to
ded0712
Compare
Owner
|
The checks are failing on this PR |
NSPC911
force-pushed
the
transparent-halfcell
branch
3 times, most recently
from
45e7a11 to
bf0bd5a
Compare
NSPC911
force-pushed
the
transparent-halfcell
branch
from
bf0bd5a to
19dd58c
Compare
Author
|
Hi @lnqs, can you take a look at this again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before
after
