Skip to content

[WebAssembly] Mark externref as not being valid vector elements #71069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pmatos wants to merge 2 commits into from
+20 −1
Closed

[WebAssembly] Mark externref as not being valid vector elements #71069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deb62d8
[WebAssembly] Reftypes are not valid element types
pmatos Oct 31, 2023
d93ec3a
Add test
pmatos Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions clang/test/CodeGen/WebAssembly/wasm-externref-novec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// RUN: %clang_cc1 -O2 -triple wasm32-unknown-unknown-wasm -emit-llvm -o - %s | FileCheck %s

// From issue 69894. Reftypes need to be marked as not valid as vector elements.
__externref_t foo(void);
void bar(__externref_t);

void
test(int flag, __externref_t ref1, __externref_t ref2)
{
if (flag) {
ref1 = foo();
ref2 = foo();
}
bar(ref1);
bar(ref2);
}
5 changes: 4 additions & 1 deletion llvm/lib/IR/Type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,8 +682,11 @@ VectorType *VectorType::get(Type *ElementType, ElementCount EC) {
}

bool VectorType::isValidElementType(Type *ElemTy) {
if(PointerType *PTy = dyn_cast<PointerType>(ElemTy))
return PTy->getAddressSpace() != 10 && PTy->getAddressSpace() != 20;

return ElemTy->isIntegerTy() || ElemTy->isFloatingPointTy() ||
ElemTy->isPointerTy() || ElemTy->getTypeID() == TypedPointerTyID;
ElemTy->getTypeID() == TypedPointerTyID;
}

//===----------------------------------------------------------------------===//
Expand Down