router: fix epponly http port for agentgateway proxyType#1655
Open
abhay1999 wants to merge 2 commits into
Open
router: fix epponly http port for agentgateway proxyType#1655abhay1999 wants to merge 2 commits into
abhay1999 wants to merge 2 commits into
Conversation
_normalize_router_block always hardcoded targetPort: 8081 for the epponly http service port, since that's where envoy's sidecar listens. but the chart's own validation rejects a raw port number there when proxyType=agentgateway, it only accepts targetPort omitted, 80, or the literal string "http". confirmed this by running the actual llm-d-router-standalone chart with helm template against a rendered epponly+agentgateway scenario, it failed with exactly that validation error. picking targetPort based on proxyType (http for agentgateway, 8081 for envoy/default) fixes it, verified the same helm template run passes afterwards. Signed-off-by: Abhay Chaurasiya <abhaychaurasiya19@gmail.com>
abhay1999
requested review from
Vezio,
achandrasekar,
kalantar,
maugustosilva,
mengmeiye and
namasl
as code owners
July 17, 2026 09:59
…-specific Nina's feedback on the earlier commit here: don't special-case proxyType=agentgateway in the code, just make the port configurable. router.proxy.httpTargetPort now controls the epponly http service port directly, defaults to 8081 (unchanged envoy behavior) if not set. A scenario that wants agentgateway sets both proxyType and httpTargetPort: "http" together, no proxyType-aware branching in render_plans.py anymore. Reran the same helm template check against the real chart with this version of the fix, still passes clean. Signed-off-by: Abhay Chaurasiya <abhaychaurasiya19@gmail.com>
Author
|
update based on feedback from nina on slack: dropped the proxyType check entirely, its now just router.proxy.httpTargetPort as a plain override, defaults to 8081 (same as before) if not set. a scenario going for agentgateway sets proxyType: agentgateway and httpTargetPort: "http" together, no branching on proxy type name in the code anymore. reran the same helm template check against the real chart, still passes clean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
_normalize_router_block always hardcodes targetPort: 8081 for the epponly http service port, since thats where envoy's sidecar listens. but the chart's own validation rejects a raw port number there when proxyType=agentgateway, it only accepts targetPort omitted, 80, or the literal string "http". so any epponly scenario that sets proxyType: agentgateway fails at helm template time even though the scenario file itself looks totally fine.
fix just picks targetPort based on proxyType now, "http" for agentgateway, 8081 for envoy same as before.
how i found and checked this
was originally trying to fix something else (no way to even pick proxyType=agentgateway for epponly), but while rebasing i noticed PR #1541 had already turned 12_router-values.yaml.j2 into a plain pass-through. so scenarios can just set router.proxy.proxyType: agentgateway directly now, didnt need a template change for that part at all.
wanted to make sure that path actually works end to end though, not just renders nice yaml. so i pulled the real llm-d-router-standalone chart and ran helm template against a rendered epponly + agentgateway scenario, and it blew up here:
patched _normalize_router_block locally, reran the exact same scenario through helm template again, passes clean this time (exit 0). also reran the default epponly scenario (no proxyType set) just to be safe, targetPort is still 8081 there, nothing changed for envoy.
testing