standup: probe decode vllm port#1603
Open
hubunt wants to merge 1 commit into
Open
Conversation
Signed-off-by: hubunt <150658615+hubunt@users.noreply.github.com>
hubunt
requested review from
Vezio,
achandrasekar,
kalantar,
maugustosilva,
mengmeiye and
namasl
as code owners
July 8, 2026 05:42
mengmeiye
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix decode pod probe ports so they target the actual vLLM bind port when routing proxy is enabled.
Motivation
Fixes #1435.
In
pd-disaggregation, decode vLLM is started with--port $VLLM_METRICS_PORT, which resolves to8200. However, the rendered ModelService values useddecode.vllm.servicePort(8000) as the default decode probe port. This can cause decode pod readiness checks to fail even though vLLM is listening on 8200.What changed
decode.vllm.portdecode.vllm.servicePortdecode.probes.*.portoverrides are preserved.pd-disaggregationscenario and verifying decode startup/liveness/readiness probes use8200.Testing
python -m pytest tests/test_decode_probe_port.py -qpython -m pytest tests -qpython -m py_compile tests/test_decode_probe_port.pygit diff --checkBackward Compatibility
Scenarios with explicit probe port overrides are unchanged. When routing proxy is disabled, decode probes continue to default to
decode.vllm.servicePort.