Support advertise internal ip with external ip#88
Merged
Conversation
Also add option to skip external ip validation
cnderrauber
changed the title
paulwe
approved these changes
Jun 1, 2026
cnderrauber
added a commit
to livekit/livekit
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option
advertise_internal_ip, only work withuse_external_ip:true:In some deployment architectures, both internal and external clients need to connect to SFU, but due to network settings, internal clients can only connect via their internal IP addresses. This pull request adds an option to broadcast both internal and external IP addresses simultaneously for this case.
Option
skip_external_ip_validation, only work withuse_external_ip:true:Sfu will use a self-ping to detect the external ip accessibility, disable it by this option in case like #85 .