Skip to content

Fix all compiler warnings in 2022.3.62 #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxHeimbrock wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix all compiler warnings in 2022.3.62 #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e6a543
Remove annotation of obsolete usage
MaxHeimbrock Jul 3, 2026
9aad080
Reducing warnings in tests
MaxHeimbrock Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Runtime/Scripts/Core/Room.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ public Proto.RoomOptions ToProto()
proto.AdaptiveStream = AdaptiveStream;
proto.JoinRetries = JoinRetries;
proto.RtcConfig = RtcConfig?.ToProto();
#pragma warning disable CS0612 // Type or member is obsolete
proto.E2Ee = E2EE?.ToProto();

return proto;
Expand Down
16 changes: 8 additions & 8 deletions Tests/PlayMode/RpcTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ public IEnumerator RegisterRpcMethod_AndPerformRpc_ReturnsResponse()
yield return context.ConnectAll();
Assert.IsNull(context.ConnectionError, context.ConnectionError);

context.Rooms[1].LocalParticipant.RegisterRpcMethod("echo", async (data) =>
context.Rooms[1].LocalParticipant.RegisterRpcMethod("echo", (data) =>
{
return $"echo:{data.Payload}";
return Task.FromResult($"echo:{data.Payload}");
});

var rpcInstruction = context.Rooms[0].LocalParticipant.PerformRpc(new PerformRpcParams
Expand Down Expand Up @@ -58,9 +58,9 @@ public IEnumerator PerformRpc_HandlerThrowsRpcError_PropagatesError()
yield return context.ConnectAll();
Assert.IsNull(context.ConnectionError, context.ConnectionError);

context.Rooms[1].LocalParticipant.RegisterRpcMethod("throw-rpc", async (data) =>
context.Rooms[1].LocalParticipant.RegisterRpcMethod("throw-rpc", (data) =>
{
throw new RpcError(42, "custom error", "custom data");
return Task.FromException<string>(new RpcError(42, "custom error", "custom data"));
});

var rpcInstruction = context.Rooms[0].LocalParticipant.PerformRpc(new PerformRpcParams
Expand Down Expand Up @@ -90,9 +90,9 @@ public IEnumerator PerformRpc_HandlerThrowsGenericException_ReturnsApplicationEr
yield return context.ConnectAll();
Assert.IsNull(context.ConnectionError, context.ConnectionError);

context.Rooms[1].LocalParticipant.RegisterRpcMethod("throw-generic", async (data) =>
context.Rooms[1].LocalParticipant.RegisterRpcMethod("throw-generic", (data) =>
{
throw new InvalidOperationException("something went wrong");
return Task.FromException<string>(new InvalidOperationException("something went wrong"));
});

var rpcInstruction = context.Rooms[0].LocalParticipant.PerformRpc(new PerformRpcParams
Expand Down Expand Up @@ -147,9 +147,9 @@ public IEnumerator UnregisterRpcMethod_ThenPerformRpc_ReturnsUnsupportedMethod()
yield return context.ConnectAll();
Assert.IsNull(context.ConnectionError, context.ConnectionError);

context.Rooms[1].LocalParticipant.RegisterRpcMethod("unreg-test", async (data) =>
context.Rooms[1].LocalParticipant.RegisterRpcMethod("unreg-test", (data) =>
{
return "should not reach here";
return Task.FromResult("should not reach here");
});
context.Rooms[1].LocalParticipant.UnregisterRpcMethod("unreg-test");

Expand Down
Loading