Skip to content

Fix dropped first chunk in incremental stream readers #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxHeimbrock wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −4
Open

Fix dropped first chunk in incremental stream readers #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Runtime/Scripts/DataStreams/ByteDataStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,14 @@ public ReadIncrementalInstruction ReadIncremental()
using var request = FFIBridge.Instance.NewRequest<ByteStreamReaderReadIncrementalRequest>();
var readIncReq = request.request;
readIncReq.ReaderHandle = (ulong)_handle.DangerousGetHandle();
request.Send();

return new ReadIncrementalInstruction(_handle);
// Subscribe before sending: chunk events are delivered directly on the FFI
// callback thread, and the FFI server emits already-buffered chunks as soon
// as it receives the request. Sending first loses any chunk emitted before
// the subscription exists.
var instruction = new ReadIncrementalInstruction(_handle);
request.Send();
return instruction;
}

/// <summary>
Expand Down
9 changes: 7 additions & 2 deletions Runtime/Scripts/DataStreams/TextDataStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,14 @@ public ReadIncrementalInstruction ReadIncremental()
using var request = FFIBridge.Instance.NewRequest<TextStreamReaderReadIncrementalRequest>();
var readIncReq = request.request;
readIncReq.ReaderHandle = (ulong)_handle.DangerousGetHandle();
request.Send();

return new ReadIncrementalInstruction(_handle);
// Subscribe before sending: chunk events are delivered directly on the FFI
// callback thread, and the FFI server emits already-buffered chunks as soon
// as it receives the request. Sending first loses any chunk emitted before
// the subscription exists.
var instruction = new ReadIncrementalInstruction(_handle);
request.Send();
return instruction;
}

/// <summary>
Expand Down
Loading