Skip to content

fix(proguard): scope protobuf keep rule to SDK-generated messages #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrian-niculescu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(proguard): scope protobuf keep rule to SDK-generated messages #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-mangos-scope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"client-sdk-android": patch
---

Scoped the protobuf consumer keep rule to the SDK's generated messages and the well-known types they embed, instead of every GeneratedMessageLite subclass in the consuming app.
5 changes: 4 additions & 1 deletion livekit-android-sdk/consumer-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@

# Protobuf
#########################################
-keepclassmembers class * extends com.google.protobuf.GeneratedMessageLite {
-keepclassmembers class livekit.** extends com.google.protobuf.GeneratedMessageLite {
<fields>;
}
-keepclassmembers class com.google.protobuf.** extends com.google.protobuf.GeneratedMessageLite {
<fields>;
}