Lime revocation and relinking improvements#927
Merged
Conversation
We cannot assume the email was sent/processed.
We need to handle relay messages even if the user is no longer eligible for a service; the individual message handlers can figure out what to do from there.
We were requiring a payment instrument, but NOT requiring the account to be paid up before re-linking. This prevents relinking unless the user is paid up. It also guards against relinking if services are prohibited.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 750 750
Lines 37226 37253 +27
=======================================
+ Hits 37162 37189 +27
Misses 64 64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendor account link: require balance payoff
We were requiring a payment instrument, but NOT requiring
the account to be paid up before re-linking.
This prevents relinking unless the user is paid up.
It also guards against relinking if services are prohibited.
Add link to provision member contact to vendor account page
Standardize field displays on resource detail page
AnonProxy: handle messages when ineligible
We need to handle relay messages even if the user is no longer
eligible for a service; the individual message handlers
can figure out what to do from there.
Allow admins to retry revoking Lime account
We cannot assume the email was sent/processed.