Stage 8 credential memory hygiene#139
Open
YoshiyukiSakura wants to merge 2 commits into
Open
Conversation
Delivery Evidence SummaryChange:
Objective Evidence:
Visual Evidence:
Reviewer:
Risks / Not Covered:
Generated at: 2026-05-28T08:26:11.532Z |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3
Summary
Sessiondebug output.SecretBytesacross core, S3, MCP, daemon tests, mock clients, and provisioner tests.agentkeys initbehavior plus--force, and wrap CLIread/runcredential strings inZeroizingwhile in process.Change:
Stage 8 hardening slice for credential memory hygiene and CLI defensive behavior. Adds zeroize-backed credential/session handling and idempotent init with force override.
Objective Evidence:
cargo check -p agentkeys-types -p agentkeys-core -p agentkeys-mcp -p agentkeys-provisioner -p agentkeys-clipassed.cargo test -p agentkeys-types -p agentkeys-clipassed.cargo test --workspacepassed.Visual Evidence:
n.a. Backend/CLI-only Rust changes; no UI/browser/visual behavior was touched.
Reviewer:
@repo Intake Reviewer
Risks / Not Covered:
This is the smallest safe Stage 8 slice. Daemon-mediated
cmd_run, SCM_RIGHTS/memfd delivery, idle eviction, daemon audit trail, Priority B binary/runtime hardening, and storage hardening remain follow-up work for the broader Stage 8 plan.