Skip to content

Stage 8 credential memory hygiene#139

Open
YoshiyukiSakura wants to merge 2 commits into
mainfrom
worktree/task_72ff3c95708f4fae
Open

Stage 8 credential memory hygiene#139
YoshiyukiSakura wants to merge 2 commits into
mainfrom
worktree/task_72ff3c95708f4fae

Conversation

@YoshiyukiSakura
Copy link
Copy Markdown
Contributor

Refs #3

Summary

  • Wrap session tokens and credential read results in zeroizing containers, with redacted Session debug output.
  • Route credential read plumbing through SecretBytes across core, S3, MCP, daemon tests, mock clients, and provisioner tests.
  • Add idempotent agentkeys init behavior plus --force, and wrap CLI read/run credential strings in Zeroizing while in process.

Change:
Stage 8 hardening slice for credential memory hygiene and CLI defensive behavior. Adds zeroize-backed credential/session handling and idempotent init with force override.

Objective Evidence:

  • cargo check -p agentkeys-types -p agentkeys-core -p agentkeys-mcp -p agentkeys-provisioner -p agentkeys-cli passed.
  • cargo test -p agentkeys-types -p agentkeys-cli passed.
  • cargo test --workspace passed.

Visual Evidence:
n.a. Backend/CLI-only Rust changes; no UI/browser/visual behavior was touched.

Reviewer:
@repo Intake Reviewer

Risks / Not Covered:
This is the smallest safe Stage 8 slice. Daemon-mediated cmd_run, SCM_RIGHTS/memfd delivery, idle eviction, daemon audit trail, Priority B binary/runtime hardening, and storage hardening remain follow-up work for the broader Stage 8 plan.

@crossagent-production-app
Copy link
Copy Markdown

crossagent-production-app Bot commented May 28, 2026

Delivery Evidence Summary

Change:

  • Stage 8 hardening slice for credential memory hygiene and CLI defensive behavior.
  • Wrap session tokens and credential read results in zeroizing containers with redacted Session debug output.
  • Add idempotent agentkeys init behavior with --force and zeroizing around CLI read/run credential strings.
  • Make broker nginx site symlink enabling idempotent so path-conditional deploy checks can rerun on existing test hosts.

Objective Evidence:

  • cargo check -p agentkeys-types -p agentkeys-core -p agentkeys-mcp -p agentkeys-provisioner -p agentkeys-cli exit code 0, passed
  • cargo test -p agentkeys-types -p agentkeys-cli exit code 0, passed
  • cargo test --workspace exit code 0, passed
  • bash -n scripts/setup-broker-host.sh exit code 0, passed

Visual Evidence:

  • n.a.

Reviewer:

Risks / Not Covered:

Generated at: 2026-05-28T08:26:11.532Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant