test: add unit tests for /chat endpoint - #4
Open
lireno wants to merge 1 commit into
Open
Conversation
Add comprehensive tests for the /chat endpoint and underlying openai_chat_stream / convert_to_openai_messages functions. Unit tests cover: - convert_to_openai_messages: user/assistant messages, tool invocations, mixed messages, empty lists, tool invocations without results - openai_chat_stream: text delta streaming, tool call streaming, empty stream handling (with mock OpenAI client) Integration tests cover: - Happy path: streaming response with proper SSE format and headers - Empty messages list - Missing API key (403) - Invalid API key (401) - Missing required request body fields (422) - Messages containing tool invocations Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit and integration tests for the /chat endpoint and its underlying functions (openai_chat_stream, convert_to_openai_messages), which previously had zero test coverage.
Changes
Unit tests for convert_to_openai_messages
Unit tests for openai_chat_stream
Integration tests for /chat endpoint
Testing
The tests follow existing patterns in the codebase:
To run:
🤖 Generated with Claude Code