[Networking] Geneve tunnel conncheck#3277
Open
cheina97 wants to merge 7 commits into
Open
Conversation
Collaborator
|
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
cheina97
force-pushed
the
frc/genevetunnelping
branch
from
May 4, 2026 08:21
ee5dcff to
68f9eb6
Compare
Member
Author
|
/build |
cheina97
force-pushed
the
frc/genevetunnelping
branch
from
July 16, 2026 15:11
68f9eb6 to
c90370f
Compare
cheina97
force-pushed
the
frc/genevetunnelping
branch
4 times, most recently
from
July 16, 2026 16:06
55a42bf to
c854f19
Compare
cheina97
force-pushed
the
frc/genevetunnelping
branch
3 times, most recently
from
July 16, 2026 21:29
0e38cb0 to
4ff859a
Compare
Member
Author
|
/rebase test=true |
frisso
reviewed
Jul 17, 2026
frisso
reviewed
Jul 17, 2026
frisso
reviewed
Jul 17, 2026
frisso
reviewed
Jul 17, 2026
frisso
reviewed
Jul 17, 2026
cheina97
force-pushed
the
frc/genevetunnelping
branch
2 times, most recently
from
July 17, 2026 11:48
32e3c77 to
26838e2
Compare
…vetunnels.yaml Co-authored-by: Fulvio Risso <fulvio.risso@polito.it>
…vetunnels.yaml Co-authored-by: Fulvio Risso <fulvio.risso@polito.it>
Co-authored-by: Fulvio Risso <fulvio.risso@polito.it>
cheina97
force-pushed
the
frc/genevetunnelping
branch
2 times, most recently
from
July 17, 2026 11:53
76f3521 to
84a6398
Compare
Member
Author
|
/rebase test=true |
Co-authored-by: Fulvio Risso <fulvio.risso@polito.it>
cheina97
force-pushed
the
frc/genevetunnelping
branch
from
July 17, 2026 13:10
84a6398 to
830350b
Compare
Member
Author
|
/rebase test=true |
fra98
approved these changes
Jul 18, 2026
Comment on lines
+59
to
+68
| flagset.BoolVar(&opts.PingEnabled, FlagNameGenevePingEnabled.String(), true, | ||
| "Enable geneve tunnel ping health check") | ||
| flagset.IntVar(&opts.ConnCheckOptions.PingPort, FlagNameGenevePingPort.String(), 12346, | ||
| "UDP port used for geneve tunnel ping health check") | ||
| flagset.DurationVar(&opts.ConnCheckOptions.PingInterval, FlagNameGenevePingInterval.String(), 2*time.Second, | ||
| "Interval between geneve tunnel pings") | ||
| flagset.UintVar(&opts.ConnCheckOptions.PingLossThreshold, FlagNameGenevePingLossThreshold.String(), 5, | ||
| "Number of consecutive lost pings before a geneve tunnel is declared down") | ||
| flagset.DurationVar(&opts.PingUpdateStatusInterval, FlagNameGenevePingUpdateStatusInterval.String(), 10*time.Second, | ||
| "Minimum interval between GeneveTunnel status updates") |
Member
There was a problem hiding this comment.
Would be nice to have some of these configurable from Helm like we have for wireguard ping
cheina97
force-pushed
the
frc/genevetunnelping
branch
from
July 19, 2026 21:10
e13d559 to
d103c5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an active connectivity health-check (ping) mechanism for Geneve tunnels, tracking connection status and latency directly on the
GeneveTunnelCRD.What changed:
GeneveTunnelCRD extended — added aStatussubresource withvalue(Connected/Error) andlatencyfields, pluskubectl getprint columns for quick status inspection.InternalNodeReconciler— on reconcile, lazily initialises aConnCheckerbound to the gateway's inner Geneve IP; registers a UDP ping sender per tunnel and wires a callback that writes connectivity results back toGeneveTunnelstatus. Senders are stopped when the correspondingInternalNodeis deleted.InternalFabricReconciler— lazily starts aConnCheckerreceiver bound to the node's inner Geneve IP, so the fabric side can respond to pings from the gateway.ConnCheckerimprovements:BindIPoption), enabling per-interface isolation between Geneve and WireGuard ping traffic.PingLatencyAlphaoption, default 0.1) instead of using raw per-packet measurements.geneve-fabriccomponent):--geneve-ping-enabled(defaulttrue)--geneve-ping-port(default12346)--geneve-ping-interval(default2s)--geneve-ping-loss-threshold(default5)--geneve-ping-update-status-interval(default10s)--geneve-ping-latency-alpha(default0.1)--geneve-ping-portmust match the gateway value.--ping-latency-alphaapplies the same EWMA smoothing to WireGuard connection checks.How it works
When
--geneve-ping-enabled=falsethe status is set toConnectedimmediately without running the ping loop.Test plan
kubectl get genevetunnelsshowsConnectedand a latency value after a few seconds.InternalNode; verify no goroutine leak (sender is stopped).--geneve-ping-enabled=false; verify status is immediatelyConnected.