Enable cobalt browser tests for media* tests

.github/actionlint.yaml

@@ -0,0 +1,20 @@
+# Configuration related to self-hosted runner.
+self-hosted-runner:
+  # Labels of self-hosted runner in array of strings.
+  labels:
+    - chrobalt-linux-runner
+    - odt-runner
+
+# Path-specific configurations.
+paths:
+  # TODO: Outstanding linting failures
+  .github/workflows/main.yaml:
+    # List of regular expressions to filter errors by the error messages.
+    ignore:
+      # Ignore the specific error from shellcheck
+      - 'shellcheck reported issue in this script: (SC2004|SC2086):.+'
+  .github/workflows/label-cherry-pick.yaml:
+    # List of regular expressions to filter errors by the error messages.
+    ignore:
+      # Ignore the specific error from shellcheck
+      - 'shellcheck reported issue in this script: (SC2053|SC2076|SC2199|SC2086):.+'

.github/actions/internal_tests/action.yaml

@@ -77,6 +77,7 @@ runs:
           --label repository-${GITHUB_REPO} \
           --label author-${GITHUB_PR_HEAD_USER_LOGIN:-$GITHUB_COMMIT_AUTHOR_USERNAME} \
           --label author_id-${GITHUB_PR_HEAD_USER_ID:-$GITHUB_COMMIT_AUTHOR_EMAIL} \
+          --label branch:${GITHUB_REF_NAME} \
           --dimensions '${{ inputs.test_dimensions }}' \
           --cobalt_path "${GCS_ARTIFACTS_PATH}" || {
             echo "Finished running tests..."

.github/actions/on_device_tests/action.yaml

@@ -87,6 +87,7 @@ runs:
           --label repository-${GITHUB_REPO} \
           --label author-${GITHUB_PR_HEAD_USER_LOGIN:-$GITHUB_COMMIT_AUTHOR_USERNAME} \
           --label author_id-${GITHUB_PR_HEAD_USER_ID:-$GITHUB_COMMIT_AUTHOR_EMAIL} \
+          --label branch:${GITHUB_REF_NAME} \
           --dimensions '${{ inputs.test_dimensions }}' \
           ${TEST_ATTEMPTS:+"--test_attempts" "$TEST_ATTEMPTS"} \
           --gcs_archive_path "${GCS_ARTIFACTS_PATH}" \

.github/workflows/label-cherry-pick.yaml

@@ -114,7 +114,7 @@ jobs:
             ${{ github.event.pull_request.body }}
 
       - name: Comment on failure
-        uses: actions/github-script@v6
+        uses: actions/github-script@v8
         with:
           github-token: ${{ secrets.CHERRY_PICK_TOKEN }}
           script: |

.github/workflows/lint.yaml

@@ -12,7 +12,7 @@ on:
       - feature/*
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.event_name }}-${{ inputs.platform }} @ ${{ github.event.label.name || github.event.pull_request.number || github.sha }} @ ${{ github.event.label.name && github.event.pull_request.number || github.event.action }}
+  group: ${{ github.workflow }}-${{ github.event_name }} @ ${{ github.event.label.name || github.event.pull_request.number || github.sha }} @ ${{ github.event.label.name && github.event.pull_request.number || github.event.action }}
   cancel-in-progress: true
 
 permissions: {}

.github/workflows/main.yaml

@@ -13,7 +13,6 @@ on:
         description: 'Nightly workflow.'
         required: true
         type: string
-        default: 'false'
       run_api_leak_detector:
         description: 'Whether to run the api leak detector.'
         required: false

.pre-commit-config.yaml

@@ -36,6 +36,11 @@ repos:
     -   id: end-of-file-fixer
     -   id: mixed-line-ending
     -   id: trailing-whitespace
+-   repo: https://github.com/rhysd/actionlint
+    rev: 03d0035246f3e81f36aed592ffb4bebf33a03106
+    hooks:
+    -   id: actionlint
+        files: ^.github/workflows
 -   repo: local
     hooks:
     -   id: chromium-pre-commit

build/android/gyp/java_cpp_features.py

@@ -18,10 +18,11 @@
 
 class FeatureParserDelegate(java_cpp_utils.CppConstantParser.Delegate):
   # Ex. 'BASE_FEATURE(kConstantName, "StringNameOfTheFeature", ...);'
+  # or 'STARBOARD_FEATURE(kConstantName, "StringNameOfTheFeature", ...);'
   # would parse as:
   #   ExtractConstantName() -> 'ConstantName'
   #   ExtractValue() -> '"StringNameOfTheFeature"'
-  FEATURE_RE = re.compile(r'BASE_FEATURE\(k([^,]+),')
+  FEATURE_RE = re.compile(r'(?:BASE_FEATURE|STARBOARD_FEATURE)\(k([^,]+),')
   VALUE_RE = re.compile(r'\s*("(?:\"|[^"])*")\s*,')
 
   def ExtractConstantName(self, line):

cobalt/BUILD.gn

@@ -96,6 +96,7 @@ if (is_ios && target_platform == "tvos") {
       "//cobalt/shell:cobalt_shell_app",
       "//cobalt/shell:cobalt_shell_lib",
       "//content/public/app",
+      "//starboard:starboard_group",
     ]
     bundle_deps = [
       ":cobalt_shell_framework_resources",
@@ -242,6 +243,7 @@ test("cobalt_unittests") {
     "//cobalt/browser/client_hint_headers/cobalt_header_value_provider_test.cc",
     "//cobalt/browser/client_hint_headers/cobalt_trusted_header_client_test.cc",
     "//cobalt/browser/client_hint_headers/cobalt_trusted_url_loader_header_client_test.cc",
+    "//cobalt/browser/command_line_logger_unittest.cc",
     "//cobalt/browser/experiments/experiment_config_manager_unittest.cc",
     "//cobalt/browser/global_features_unittest.cc",
     "//cobalt/browser/h5vcc_runtime/deep_link_manager_unittest.cc",
@@ -270,6 +272,7 @@ test("cobalt_unittests") {
     ":common",
     "//base/test:run_all_unittests",
     "//base/test:test_support",
+    "//cobalt/browser:command_line_logger",
     "//cobalt/browser:global_features",
     "//cobalt/browser:metrics",
     "//cobalt/browser/client_hint_headers",

cobalt/android/BUILD.gn

@@ -15,6 +15,15 @@ jinja_template("cobalt_manifest") {
   ]
 }
 
+java_cpp_features("java_features_srcjar") {
+  # External code should depend on ":cobalt_features_java" instead.
+  visibility = [ ":*" ]
+  sources = [ "//starboard/extension/feature_config.h" ]
+
+  deps = [ "//starboard/extension:feature_config_header" ]
+  template = "//cobalt/android/java_templates/StarboardFeatures.java.tmpl"
+}
+
 generate_jni("jni_headers") {
   sources = [
     "apk/app/src/main/java/dev/cobalt/coat/AudioPermissionRequester.java",
@@ -26,6 +35,7 @@ generate_jni("jni_headers") {
     "apk/app/src/main/java/dev/cobalt/coat/ResourceOverlay.java",
     "apk/app/src/main/java/dev/cobalt/coat/StarboardBridge.java",
     "apk/app/src/main/java/dev/cobalt/coat/javabridge/HTMLMediaElementExtension.java",
+    "apk/app/src/main/java/dev/cobalt/features/StarboardFeatureList.java",
     "apk/app/src/main/java/dev/cobalt/media/AudioOutputManager.java",
     "apk/app/src/main/java/dev/cobalt/media/AudioTrackBridge.java",
     "apk/app/src/main/java/dev/cobalt/media/MediaCodecBridge.java",
@@ -100,6 +110,7 @@ android_library("cobalt_main_java") {
   }
 
   srcjar_deps = [
+    ":java_features_srcjar",
     ":jni_headers",
     "//starboard/android/shared:java_enums",
   ]
@@ -134,6 +145,7 @@ android_library("cobalt_main_java") {
     "apk/app/src/main/java/dev/cobalt/coat/javabridge/CobaltJavaScriptInterface.java",
     "apk/app/src/main/java/dev/cobalt/coat/javabridge/H5vccPlatformService.java",
     "apk/app/src/main/java/dev/cobalt/coat/javabridge/HTMLMediaElementExtension.java",
+    "apk/app/src/main/java/dev/cobalt/features/StarboardFeatureList.java",
     "apk/app/src/main/java/dev/cobalt/libraries/services/clientloginfo/ClientLogInfo.java",
     "apk/app/src/main/java/dev/cobalt/libraries/services/clientloginfo/ClientLogInfoModule.java",
     "apk/app/src/main/java/dev/cobalt/media/AudioOutputManager.java",

cobalt/android/apk/app/src/main/java/dev/cobalt/coat/CobaltActivity.java

@@ -26,6 +26,7 @@
 import android.net.Uri;
 import android.os.Bundle;
 import android.os.SystemClock;
+import android.text.TextUtils;
 import android.view.KeyEvent;
 import android.view.View;
 import android.view.ViewGroup.LayoutParams;

cobalt/android/apk/app/src/main/java/dev/cobalt/coat/CobaltConnectivityDetector.java

@@ -106,16 +106,19 @@ public void activeNetworkCheck() {
                 } else {
                   handleFailure();
                 }
+              // Don't raise the error dialog if the thread is intentionally interrupted.
+              // Otherwise handleFailure() for timeout exceptions and all other exceptions.
               } catch (TimeoutException e) {
                 handleFailure();
               } catch (Exception e) {
-                if (e instanceof InterruptedException) {
+                if (e instanceof InterruptedException || e instanceof java.util.concurrent.CancellationException) {
                   Thread.currentThread().interrupt(); // Preserve interrupt status.
+                } else {
+                  Log.w(TAG, "Connectivity check failed with exception: " + e.getClass().getName(), e);
+                  handleFailure();
                 }
-                Log.w(TAG, "Connectivity check failed with exception: " + e.getClass().getName(), e);
-                handleFailure();
               } finally {
-                // This is crucial. It ensures the probe thread is discarded.
+                // Ensuring the probe thread is discarded.
                 probeExecutor.shutdownNow();
               }
             });

cobalt/android/apk/app/src/main/java/dev/cobalt/features/StarboardFeatureList.java

@@ -0,0 +1,46 @@
+// Copyright 2025 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package dev.cobalt.features;
+
+import org.chromium.base.FeatureList;
+import org.chromium.build.annotations.NullMarked;
+import org.jni_zero.JNINamespace;
+import org.jni_zero.NativeMethods;
+
+/** A FeatureList for our Starboard features to be used in Java. */
+@JNINamespace("starboard::features")
+@NullMarked
+public class StarboardFeatureList {
+    private StarboardFeatureList() {}
+    /**
+     * Returns whether the specified feature is enabled or not.
+     *
+     * Note: This queries features defined with STARBOARD_FEATURE in
+     * //starboard/extension/feature_config.h
+     *
+     * @param featureName The name of the feature to query.
+     * @return Whether the feature is enabled or not.
+     */
+    public static boolean isEnabled(String featureName) {
+        assert FeatureList.isNativeInitialized();
+        return StarboardFeatureListJni.get().isEnabled(featureName);
+    }
+
+    /** Native Methods for StarboardFeatureList. */
+    @NativeMethods
+    public interface Natives {
+        boolean isEnabled(String featureName);
+    }
+}

cobalt/android/java_templates/StarboardFeatures.java.tmpl

@@ -0,0 +1,26 @@
+// Copyright 2025 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+ package dev.cobalt.features;
+
+ /**
+  * Contains features that are specific to Starboard code.
+  */
+ public final class StarboardFeatures {{
+
+ {NATIVE_FEATURES}
+
+     // Prevents instantiation.
+     private StarboardFeatures() {{}}
+ }}

cobalt/app/tvos/main.mm

@@ -27,6 +27,8 @@
 #include "cobalt/shell/browser/shell.h"
 #include "content/public/app/content_main.h"
 #include "content/public/app/content_main_runner.h"
+#include "starboard/common/command_line.h"
+#include "starboard/tvos/shared/application_darwin.h"
 
 static int g_argc = 0;
 static const char** g_argv = nullptr;
@@ -58,6 +60,7 @@ @interface CobaltAppDelegate : UIResponder <UIApplicationDelegate> {
  @private
   std::unique_ptr<content::ContentMainRunner> _mainRunner;
   std::unique_ptr<cobalt::CobaltMainDelegate> _mainDelegate;
+  std::unique_ptr<starboard::ApplicationDarwin> _starboardApplication;
 }
 @end
 
@@ -80,6 +83,13 @@ - (BOOL)application:(UIApplication*)application
   const base::CommandLine::StringVector& processed_argv =
       cobalt_cmd_line.argv();
 
+  // Initialize ApplicationDarwin before the content layer. This is required to
+  // enable audio playback via the audio sink, initialize PlaybackCapabilities,
+  // and set a valid command line, all of which are essential for proper
+  // operation of the Starboard media renderer.
+  _starboardApplication = std::make_unique<starboard::ApplicationDarwin>(
+      std::make_unique<starboard::CommandLine>(processed_argv));
+
   // content::ContentMainParams::argv uses regular char** for `argv`, so perform
   // a type conversion here. Note that even though `char_argv` is dependent on
   // the function-scoped `processed_argv`, content::RunContentProcess() copies

cobalt/browser/BUILD.gn

@@ -13,6 +13,7 @@
 # limitations under the License.
 
 import("//starboard/build/buildflags.gni")
+import("//testing/test.gni")
 
 source_set("browser") {
   # TODO(cobalt, b/375655377): remove testonly declaration, needed because of
@@ -42,6 +43,7 @@ source_set("browser") {
   public_deps = [ "//content/public/browser" ]
 
   deps = [
+    ":command_line_logger",
     ":features",
     ":global_features",
     ":metrics",
@@ -150,3 +152,11 @@ source_set("metrics") {
     "//url",
   ]
 }
+
+source_set("command_line_logger") {
+  sources = [
+    "command_line_logger.cc",
+    "command_line_logger.h",
+  ]
+  deps = [ "//base" ]
+}

cobalt/browser/cobalt_content_browser_client.cc

@@ -33,6 +33,7 @@
 #include "cobalt/browser/cobalt_browser_main_parts.h"
 #include "cobalt/browser/cobalt_secure_navigation_throttle.h"
 #include "cobalt/browser/cobalt_web_contents_observer.h"
+#include "cobalt/browser/command_line_logger.h"
 #include "cobalt/browser/constants/cobalt_experiment_names.h"
 #include "cobalt/browser/features.h"
 #include "cobalt/browser/global_features.h"
@@ -534,6 +535,9 @@ void CobaltContentBrowserClient::CreateFeatureListAndFieldTrials() {
             << "], disable_features=["
             << command_line.GetSwitchValueASCII(::switches::kDisableFeatures)
             << "]";
+  LOG(INFO) << "CobaltCommandLine: "
+            << CommandLineSwitchesToString(
+                   *base::CommandLine::ForCurrentProcess());
 
   // Push the initialized features and params down to Starboard.
   features::InitializeStarboardFeatures();

cobalt/browser/command_line_logger.cc

@@ -0,0 +1,33 @@
+// Copyright 2024 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "cobalt/browser/command_line_logger.h"
+
+#include <vector>
+
+#include "base/strings/string_util.h"
+#include "base/strings/stringprintf.h"
+
+namespace cobalt {
+
+std::string CommandLineSwitchesToString(const base::CommandLine& command_line) {
+  std::vector<std::string> switch_strings;
+  for (const auto& pair : command_line.GetSwitches()) {
+    switch_strings.push_back(base::StringPrintf(
+        "'%s': '%s'", pair.first.c_str(), pair.second.c_str()));
+  }
+  return base::JoinString(switch_strings, "\n");
+}
+
+}  // namespace cobalt

cobalt/browser/command_line_logger.h

@@ -0,0 +1,29 @@
+// Copyright 2024 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef COBALT_BROWSER_COMMAND_LINE_LOGGER_H_
+#define COBALT_BROWSER_COMMAND_LINE_LOGGER_H_
+
+#include <string>
+
+#include "base/command_line.h"
+
+namespace cobalt {
+
+// Formats command line switches into a human-readable string for debugging.
+std::string CommandLineSwitchesToString(const base::CommandLine& command_line);
+
+}  // namespace cobalt
+
+#endif  // COBALT_BROWSER_COMMAND_LINE_LOGGER_H_