fix: resolve splash transition size issue#920
Open
wineee wants to merge 1 commit into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This change fixes visual glitches during prelaunch splash hide sequence. For XWayland clients, WSurface::size() returns buffer-space size which differs from scene-space after DPR scaling via surfaceSizeRatio. Additionally, a newly created QQuickItem may report 0 for implicit dimensions before polish/layout. The new implicitSizeReady property ensures we only start the transition animation when valid scene-space dimensions are available. Influence: 1. Test XWayland application launch to verify splash screen transitions smoothly without size jumps PMS: BUG-363265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes visual glitches during prelaunch splash hide sequence. For XWayland clients, WSurface::size() returns buffer-space size which differs from scene-space after DPR scaling via surfaceSizeRatio. Additionally, a newly created QQuickItem may report 0 for implicit dimensions before polish/layout. The new implicitSizeReady property ensures we only start the transition animation when valid scene-space dimensions are available.
Influence:
PMS: BUG-363265