Skip to content

fix: preserve custom URI schemes in %U/%u Exec field expansion #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lionheartyu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: preserve custom URI schemes in %U/%u Exec field expansion #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/dbus/applicationservice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1476,7 +1476,19 @@ LaunchTask ApplicationService::processExec(const QString &str, const QStringList
QList<QUrl> resources;
resources.reserve(fields.size());
for (const auto &field : fields) {
resources.emplace_back(QUrl::fromUserInput(field, dir, QUrl::AssumeLocalFile));
// Fix: preserve custom URI schemes (e.g. ksowpscloudsvr://)
// QUrl::fromUserInput() treats unknown schemes as HTTP hostnames,
// rewriting "ksowpscloudsvr://x" -> "http://ksowpscloudsvr//x".
// If the field already contains "://", parse it with TolerantMode
// (which accepts non-RFC-compliant host parts like "start=foo")
// and skip fromUserInput entirely.
QUrl url;
if (field.contains(u"://"_s)) {
url = QUrl(field, QUrl::TolerantMode);
} else {
url = QUrl::fromUserInput(field, dir, QUrl::AssumeLocalFile);
}
resources.emplace_back(std::move(url));
}

if (code.isUpper()) {
Expand Down
Loading