[暂不合并]feat(fake-wm): add dde-thp-disable pre-start script to service#269
Open
mhduiy wants to merge 1 commit into
Open
[暂不合并]feat(fake-wm): add dde-thp-disable pre-start script to service#269mhduiy wants to merge 1 commit into
mhduiy wants to merge 1 commit into
Conversation
1. Added ExecStartPre hook to run dde-thp-disable before dde-fakewm starts 2. The pre-start script ignores failure to avoid blocking service startup Log: add dde-thp-disable pre-start script to dde-fakewm service feat(fake-wm): 在服务中新增 dde-thp-disable 预启动脚本 1. 添加了 ExecStartPre 钩子，在 dde-fakewm 启动前运行 dde-thp-disable 2. 预启动脚本忽略执行失败，避免阻塞服务启动 Log: 在 dde-fakewm 服务中新增 dde-thp-disable 预启动脚本 PMS: TASK-390043
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a pre-start ExecStartPre hook to the dde-fakewm systemd service to run dde-thp-disable before the main process, while allowing failures without blocking service startup. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
deepin pr auto review你好！我是CodeGeeX。我已仔细审查了你提供的 systemd 服务单元文件的 git diff。 本次修改在 以下是我从语法逻辑、代码质量、代码性能和代码安全四个维度提出的审查意见和改进建议： 1. 语法与逻辑
2. 代码质量
3. 代码性能
4. 代码安全
综合改进建议代码如果你采纳了 CMake 变量和注释的建议，修改后的 diff 应该类似如下： diff --git a/misc/systemd/dde-fakewm.service.in b/misc/systemd/dde-fakewm.service.in
index 795ddd8..762fa36 100644
--- a/misc/systemd/dde-fakewm.service.in
+++ b/misc/systemd/dde-fakewm.service.in
@@ -8,5 +8,7 @@ After=plasma-kglobalaccel.service
Type=dbus
BusName=com.deepin.wm
ExecCondition=/bin/sh -c 'test "$XDG_SESSION_TYPE" != "wayland" || exit 2'
+# Disable THP to avoid memory fragmentation and latency issues in the desktop environment
+ExecStartPre=-@CMAKE_INSTALL_FULL_LIBEXECDIR@/dde-thp-disable
ExecStart=@CMAKE_INSTALL_FULL_BINDIR@/dde-fakewm
Slice=session.slice总结：当前的修改在语法和逻辑上是正确的， |
mhduiy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: add dde-thp-disable pre-start script to dde-fakewm service
feat(fake-wm): 在服务中新增 dde-thp-disable 预启动脚本
Log: 在 dde-fakewm 服务中新增 dde-thp-disable 预启动脚本
PMS: TASK-390043
Summary by Sourcery
Enhancements: