-
Notifications
You must be signed in to change notification settings - Fork 14
ci: This PR is to trigger periodic CI testing #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
systemroller
wants to merge
147
commits into
main
Choose a base branch
from
weekly-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
147 commits
Select commit
Hold shift + click to select a range
470385a
ci: This PR is to trigger periodic CI testing
github-actions[bot] 8f62b72
ci: This PR is to trigger periodic CI testing
github-actions[bot] e0b61ea
ci: This PR is to trigger periodic CI testing
github-actions[bot] ca12bea
ci: This PR is to trigger periodic CI testing
github-actions[bot] 67fb760
ci: This PR is to trigger periodic CI testing
github-actions[bot] 3637621
ci: This PR is to trigger periodic CI testing
github-actions[bot] cc94fa3
ci: This PR is to trigger periodic CI testing
github-actions[bot] cbe0999
ci: This PR is to trigger periodic CI testing
github-actions[bot] fb0c3eb
ci: This PR is to trigger periodic CI testing
github-actions[bot] e8e1608
ci: This PR is to trigger periodic CI testing
github-actions[bot] 7ce32be
ci: This PR is to trigger periodic CI testing
github-actions[bot] e1257c4
ci: This PR is to trigger periodic CI testing
github-actions[bot] aae4ae9
ci: This PR is to trigger periodic CI testing
github-actions[bot] cbc7502
ci: This PR is to trigger periodic CI testing
github-actions[bot] 8e94344
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2e449b4
ci: This PR is to trigger periodic CI testing
github-actions[bot] 8b8801a
ci: This PR is to trigger periodic CI testing
github-actions[bot] 9b44131
ci: This PR is to trigger periodic CI testing
github-actions[bot] d0bfdc1
ci: This PR is to trigger periodic CI testing
github-actions[bot] ba97153
ci: This PR is to trigger periodic CI testing
github-actions[bot] 04c917a
ci: This PR is to trigger periodic CI testing
github-actions[bot] 0019a56
ci: This PR is to trigger periodic CI testing
github-actions[bot] a157e4b
ci: This PR is to trigger periodic CI testing
github-actions[bot] d70859d
ci: This PR is to trigger periodic CI testing
github-actions[bot] 0582802
ci: This PR is to trigger periodic CI testing
github-actions[bot] 731ee05
ci: This PR is to trigger periodic CI testing
github-actions[bot] b9c98c2
ci: This PR is to trigger periodic CI testing
github-actions[bot] 5736add
ci: This PR is to trigger periodic CI testing
github-actions[bot] ae4caea
ci: This PR is to trigger periodic CI testing
github-actions[bot] dc5a38d
ci: This PR is to trigger periodic CI testing
github-actions[bot] b044c02
ci: This PR is to trigger periodic CI testing
github-actions[bot] c580bbf
ci: This PR is to trigger periodic CI testing
github-actions[bot] 4cd5464
ci: This PR is to trigger periodic CI testing
github-actions[bot] 8a89b9d
ci: This PR is to trigger periodic CI testing
github-actions[bot] 96467ff
ci: This PR is to trigger periodic CI testing
github-actions[bot] bc2434f
ci: This PR is to trigger periodic CI testing
github-actions[bot] 3c725df
ci: This PR is to trigger periodic CI testing
github-actions[bot] de92d72
ci: This PR is to trigger periodic CI testing
github-actions[bot] 0624c36
ci: This PR is to trigger periodic CI testing
github-actions[bot] 7bfe35c
ci: This PR is to trigger periodic CI testing
github-actions[bot] 43386f5
ci: This PR is to trigger periodic CI testing
github-actions[bot] 1de19b9
ci: This PR is to trigger periodic CI testing
github-actions[bot] 252e5b0
ci: This PR is to trigger periodic CI testing
github-actions[bot] fbd0f97
ci: This PR is to trigger periodic CI testing
github-actions[bot] c41078a
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2adfdbe
ci: This PR is to trigger periodic CI testing
github-actions[bot] b9c5b04
ci: This PR is to trigger periodic CI testing
github-actions[bot] 3a7f6fd
ci: This PR is to trigger periodic CI testing
github-actions[bot] 966a224
ci: This PR is to trigger periodic CI testing
github-actions[bot] f0066f2
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2b47653
ci: This PR is to trigger periodic CI testing
github-actions[bot] 128647d
ci: This PR is to trigger periodic CI testing
github-actions[bot] 8301878
ci: This PR is to trigger periodic CI testing
github-actions[bot] 55be4c5
ci: This PR is to trigger periodic CI testing
github-actions[bot] 5bf698f
ci: This PR is to trigger periodic CI testing
github-actions[bot] 27acc15
ci: This PR is to trigger periodic CI testing
github-actions[bot] eee591f
ci: This PR is to trigger periodic CI testing
github-actions[bot] 770e038
ci: This PR is to trigger periodic CI testing
github-actions[bot] d201c13
ci: This PR is to trigger periodic CI testing
github-actions[bot] 968f9d9
ci: This PR is to trigger periodic CI testing
github-actions[bot] fdcc4d5
ci: This PR is to trigger periodic CI testing
github-actions[bot] d88dcc1
ci: This PR is to trigger periodic CI testing
github-actions[bot] d4b2d13
ci: This PR is to trigger periodic CI testing
github-actions[bot] 734631c
ci: This PR is to trigger periodic CI testing
github-actions[bot] bcc0147
ci: This PR is to trigger periodic CI testing
github-actions[bot] b5f5905
ci: This PR is to trigger periodic CI testing
github-actions[bot] 250b0bd
ci: This PR is to trigger periodic CI testing
github-actions[bot] 6084581
ci: This PR is to trigger periodic CI testing
github-actions[bot] 936580f
ci: This PR is to trigger periodic CI testing
github-actions[bot] 0c1cea0
ci: This PR is to trigger periodic CI testing
github-actions[bot] 51dd398
ci: This PR is to trigger periodic CI testing
github-actions[bot] f44cb74
ci: This PR is to trigger periodic CI testing
github-actions[bot] 77379ca
ci: This PR is to trigger periodic CI testing
github-actions[bot] ed83794
ci: This PR is to trigger periodic CI testing
github-actions[bot] f6378c4
ci: This PR is to trigger periodic CI testing
github-actions[bot] b5943c7
ci: This PR is to trigger periodic CI testing
github-actions[bot] 7f56f74
ci: This PR is to trigger periodic CI testing
github-actions[bot] cd7e95a
ci: This PR is to trigger periodic CI testing
github-actions[bot] a622fd1
ci: This PR is to trigger periodic CI testing
github-actions[bot] c41bf05
ci: This PR is to trigger periodic CI testing
github-actions[bot] becb160
ci: This PR is to trigger periodic CI testing
github-actions[bot] cf7c092
ci: This PR is to trigger periodic CI testing
github-actions[bot] c4188f3
ci: This PR is to trigger periodic CI testing
github-actions[bot] 5b46118
ci: This PR is to trigger periodic CI testing
github-actions[bot] f6f5cb3
ci: This PR is to trigger periodic CI testing
github-actions[bot] d56fe79
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2dc8367
ci: This PR is to trigger periodic CI testing
github-actions[bot] 0f86d97
ci: This PR is to trigger periodic CI testing
github-actions[bot] 47960d4
ci: This PR is to trigger periodic CI testing
github-actions[bot] 745148f
ci: This PR is to trigger periodic CI testing
github-actions[bot] a8c0e0b
ci: This PR is to trigger periodic CI testing
github-actions[bot] af6b733
ci: This PR is to trigger periodic CI testing
github-actions[bot] ef09f10
ci: This PR is to trigger periodic CI testing
github-actions[bot] 5b2291a
ci: This PR is to trigger periodic CI testing
github-actions[bot] 8360cc3
ci: This PR is to trigger periodic CI testing
github-actions[bot] c6f679f
ci: This PR is to trigger periodic CI testing
github-actions[bot] 703f9d4
ci: This PR is to trigger periodic CI testing
github-actions[bot] eb41cf6
ci: This PR is to trigger periodic CI testing
github-actions[bot] 547f818
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2a7feae
ci: This PR is to trigger periodic CI testing
github-actions[bot] dee4062
ci: This PR is to trigger periodic CI testing
github-actions[bot] ff35f38
ci: This PR is to trigger periodic CI testing
github-actions[bot] da27360
ci: This PR is to trigger periodic CI testing
github-actions[bot] d5ba490
ci: This PR is to trigger periodic CI testing
github-actions[bot] c355fac
ci: This PR is to trigger periodic CI testing
github-actions[bot] 46fe10d
ci: This PR is to trigger periodic CI testing
github-actions[bot] 63ababc
ci: This PR is to trigger periodic CI testing
github-actions[bot] eb00b14
ci: This PR is to trigger periodic CI testing
github-actions[bot] 77b0f9b
ci: This PR is to trigger periodic CI testing
github-actions[bot] 5e5fa9e
ci: This PR is to trigger periodic CI testing
github-actions[bot] 94b54da
ci: This PR is to trigger periodic CI testing
github-actions[bot] eb121e6
ci: This PR is to trigger periodic CI testing
github-actions[bot] e852cd2
ci: This PR is to trigger periodic CI testing
github-actions[bot] 3636ec1
ci: This PR is to trigger periodic CI testing
github-actions[bot] 80edd7f
ci: This PR is to trigger periodic CI testing
github-actions[bot] ef41974
ci: This PR is to trigger periodic CI testing
github-actions[bot] 345e253
ci: This PR is to trigger periodic CI testing
github-actions[bot] 6c7909f
ci: This PR is to trigger periodic CI testing
github-actions[bot] 6c18133
ci: This PR is to trigger periodic CI testing
github-actions[bot] 1fdde98
ci: This PR is to trigger periodic CI testing
github-actions[bot] 04e1f9e
ci: This PR is to trigger periodic CI testing
github-actions[bot] 7471088
ci: This PR is to trigger periodic CI testing
github-actions[bot] 926c47e
ci: This PR is to trigger periodic CI testing
github-actions[bot] 44d1fcf
ci: This PR is to trigger periodic CI testing
github-actions[bot] caf895a
ci: This PR is to trigger periodic CI testing
github-actions[bot] 6cdb842
ci: This PR is to trigger periodic CI testing
github-actions[bot] 5f218d1
ci: This PR is to trigger periodic CI testing
github-actions[bot] 4f86153
ci: This PR is to trigger periodic CI testing
github-actions[bot] 3aa9840
ci: This PR is to trigger periodic CI testing
github-actions[bot] 77594a0
ci: This PR is to trigger periodic CI testing
github-actions[bot] ff0f625
ci: This PR is to trigger periodic CI testing
github-actions[bot] 9591865
ci: This PR is to trigger periodic CI testing
github-actions[bot] d6cd203
ci: This PR is to trigger periodic CI testing
github-actions[bot] 080d1ec
ci: This PR is to trigger periodic CI testing
github-actions[bot] fede1e6
ci: This PR is to trigger periodic CI testing
github-actions[bot] 74eef8b
ci: This PR is to trigger periodic CI testing
github-actions[bot] a8f816a
ci: This PR is to trigger periodic CI testing
github-actions[bot] 1b1ff5c
ci: This PR is to trigger periodic CI testing
github-actions[bot] c389567
ci: This PR is to trigger periodic CI testing
github-actions[bot] 1092bd1
ci: This PR is to trigger periodic CI testing
github-actions[bot] 6e8102c
ci: This PR is to trigger periodic CI testing
github-actions[bot] ab4e746
ci: This PR is to trigger periodic CI testing
github-actions[bot] db9216b
ci: This PR is to trigger periodic CI testing
github-actions[bot] 45d66c0
ci: This PR is to trigger periodic CI testing
github-actions[bot] e29133a
ci: This PR is to trigger periodic CI testing
github-actions[bot] 9cacde2
ci: This PR is to trigger periodic CI testing
github-actions[bot] c8424a7
ci: This PR is to trigger periodic CI testing
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # Copyright (C) 2023, Red Hat, Inc. | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| from __future__ import absolute_import, division, print_function | ||
|
|
||
| __metaclass__ = type | ||
|
|
||
| DOCUMENTATION = """ | ||
| author: Rich Megginson | ||
| name: dump_packages | ||
| type: aggregate | ||
| short_description: dump arguments to package module | ||
| description: | ||
| - Dump arguments to package module to get list of packages. | ||
| - Used in conjunction with CI testing to get the packages used | ||
| - with all combinations of: distribution/version/role arguments | ||
| - Used to generate lists of packages for ostree image builds. | ||
| requirements: | ||
| - None | ||
| """ | ||
|
|
||
| from ansible.plugins.callback import CallbackBase # noqa: E402 | ||
|
|
||
|
|
||
| class CallbackModule(CallbackBase): | ||
| """ | ||
| Dump packages. | ||
| """ | ||
|
|
||
| CALLBACK_VERSION = 2.0 | ||
| CALLBACK_TYPE = "aggregate" | ||
| CALLBACK_NAME = "dump_packages" | ||
| # needed for 2.9 compatibility | ||
| CALLBACK_NEEDS_WHITELIST = False # wokeignore:rule=whitelist | ||
| CALLBACK_NEEDS_ENABLED = False | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| super(CallbackModule, self).__init__(*args, **kwargs) | ||
|
|
||
| def v2_runner_on_ok(self, result): | ||
| fields = result._task_fields | ||
| if ( | ||
| fields["action"] in ["package", "dnf", "yum"] | ||
| and fields["args"].get("state") != "absent" | ||
| ): | ||
| packages = set() | ||
| if "invocation" in result._result: | ||
| results = [result._result] | ||
| elif "results" in result._result and isinstance( | ||
| result._result["results"], list | ||
| ): | ||
| results = result._result["results"] | ||
| for item in results: | ||
| pkgs = item["invocation"]["module_args"]["name"] | ||
| if isinstance(pkgs, list): | ||
| for ii in pkgs: | ||
| packages.add(ii) | ||
| else: | ||
| packages.add(pkgs) | ||
| # tell python black that this line is ok | ||
| # fmt: off | ||
| self._display.display("lsrpackages: " + " ".join(sorted(list(packages)))) | ||
| # fmt: on | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable
Copilot Autofix
AI 6 months ago
In general, to fix a “potentially uninitialized local variable” problem, either (1) initialize the variable to a safe default before any conditional assignments or (2) ensure all control-flow paths that reach its use have definitely assigned it (for example, by adding
elsecases or early returns).Here, the safest change without altering existing behavior is:
resultsto an empty list before theif/elifchain.resultsif it is non-empty; otherwise, simply skip the loop so noUnboundLocalErrorcan occur.This preserves current behavior when
resultsis defined as before, while making the code no-op (rather than crash) in the rare case that neither condition is met.Concretely in
tests/callback_plugins/dump_packages.py:CallbackModule.v2_runner_on_ok, addresults = []right afterpackages = set().for item in results:loop and subsequent package processing in anif results:guard so it only executes whenresultshas been set to something meaningful.No new imports or helper methods are required.