Skip to content
Draft
Changes from all commits
Commits
Show all changes
147 commits
Select commit Hold shift + click to select a range
470385a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 8, 2023
8f62b72
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 9, 2023
e0b61ea
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 15, 2023
ca12bea
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 22, 2023
67fb760
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 29, 2023
3637621
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 5, 2023
cc94fa3
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 12, 2023
cbe0999
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 19, 2023
fb0c3eb
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 26, 2023
e8e1608
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 3, 2023
7ce32be
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 10, 2023
e1257c4
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 17, 2023
aae4ae9
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 24, 2023
cbc7502
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 31, 2023
8e94344
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 7, 2024
2e449b4
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 14, 2024
8b8801a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 21, 2024
9b44131
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 28, 2024
d0bfdc1
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 4, 2024
ba97153
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 11, 2024
04c917a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 18, 2024
0019a56
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 25, 2024
a157e4b
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 3, 2024
d70859d
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 10, 2024
0582802
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 17, 2024
731ee05
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 24, 2024
b9c98c2
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 31, 2024
5736add
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 7, 2024
ae4caea
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 14, 2024
dc5a38d
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 21, 2024
b044c02
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 28, 2024
c580bbf
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 5, 2024
4cd5464
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 12, 2024
8a89b9d
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 19, 2024
96467ff
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 26, 2024
bc2434f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 2, 2024
3c725df
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 9, 2024
de92d72
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 16, 2024
0624c36
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 23, 2024
7bfe35c
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 30, 2024
43386f5
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 7, 2024
1de19b9
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 14, 2024
252e5b0
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 21, 2024
fbd0f97
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 28, 2024
c41078a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 4, 2024
2adfdbe
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 11, 2024
b9c5b04
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 18, 2024
3a7f6fd
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 25, 2024
966a224
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 1, 2024
f0066f2
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 8, 2024
2b47653
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 15, 2024
128647d
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 22, 2024
8301878
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 29, 2024
55be4c5
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 6, 2024
5bf698f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 13, 2024
27acc15
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 20, 2024
eee591f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 27, 2024
770e038
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 3, 2024
d201c13
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 10, 2024
968f9d9
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 17, 2024
fdcc4d5
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 24, 2024
d88dcc1
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 1, 2024
d4b2d13
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 8, 2024
734631c
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 15, 2024
bcc0147
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 22, 2024
b5f5905
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 29, 2024
250b0bd
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 5, 2025
6084581
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 12, 2025
936580f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 19, 2025
0c1cea0
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 26, 2025
51dd398
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 2, 2025
f44cb74
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 9, 2025
77379ca
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 16, 2025
ed83794
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 23, 2025
f6378c4
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 2, 2025
b5943c7
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 9, 2025
7f56f74
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 16, 2025
cd7e95a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 23, 2025
a622fd1
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 30, 2025
c41bf05
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 6, 2025
becb160
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 13, 2025
cf7c092
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 20, 2025
c4188f3
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 27, 2025
5b46118
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 4, 2025
f6f5cb3
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 11, 2025
d56fe79
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 18, 2025
2dc8367
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 25, 2025
0f86d97
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 1, 2025
47960d4
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 8, 2025
745148f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 15, 2025
a8c0e0b
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 22, 2025
af6b733
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 29, 2025
ef09f10
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 6, 2025
5b2291a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 13, 2025
8360cc3
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 20, 2025
c6f679f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 27, 2025
703f9d4
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 3, 2025
eb41cf6
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 10, 2025
547f818
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 17, 2025
2a7feae
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 24, 2025
dee4062
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 31, 2025
ff35f38
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 7, 2025
da27360
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 14, 2025
d5ba490
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 21, 2025
c355fac
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 28, 2025
46fe10d
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 5, 2025
63ababc
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 12, 2025
eb00b14
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 19, 2025
77b0f9b
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 26, 2025
5e5fa9e
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 2, 2025
94b54da
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 9, 2025
eb121e6
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 16, 2025
e852cd2
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 23, 2025
3636ec1
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 30, 2025
80edd7f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 7, 2025
ef41974
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 14, 2025
345e253
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 21, 2025
6c7909f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 28, 2025
6c18133
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 4, 2026
1fdde98
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 11, 2026
04e1f9e
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 18, 2026
7471088
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 25, 2026
926c47e
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 1, 2026
44d1fcf
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 8, 2026
caf895a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 15, 2026
6cdb842
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 22, 2026
5f218d1
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 1, 2026
4f86153
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 8, 2026
3aa9840
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 15, 2026
77594a0
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 22, 2026
ff0f625
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 29, 2026
9591865
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 5, 2026
d6cd203
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 12, 2026
080d1ec
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 14, 2026
fede1e6
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 14, 2026
74eef8b
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 19, 2026
a8f816a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 26, 2026
1b1ff5c
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 3, 2026
c389567
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 10, 2026
1092bd1
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 17, 2026
6e8102c
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 24, 2026
ab4e746
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 31, 2026
db9216b
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 7, 2026
45d66c0
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 14, 2026
e29133a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 21, 2026
9cacde2
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 28, 2026
c8424a7
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 5, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions tests/callback_plugins/dump_packages.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
# -*- coding: utf-8 -*-
# Copyright (C) 2023, Red Hat, Inc.
# SPDX-License-Identifier: MIT

from __future__ import absolute_import, division, print_function

__metaclass__ = type

DOCUMENTATION = """
author: Rich Megginson
name: dump_packages
type: aggregate
short_description: dump arguments to package module
description:
- Dump arguments to package module to get list of packages.
- Used in conjunction with CI testing to get the packages used
- with all combinations of: distribution/version/role arguments
- Used to generate lists of packages for ostree image builds.
requirements:
- None
"""

from ansible.plugins.callback import CallbackBase # noqa: E402


class CallbackModule(CallbackBase):
"""
Dump packages.
"""

CALLBACK_VERSION = 2.0
CALLBACK_TYPE = "aggregate"
CALLBACK_NAME = "dump_packages"
# needed for 2.9 compatibility
CALLBACK_NEEDS_WHITELIST = False # wokeignore:rule=whitelist
CALLBACK_NEEDS_ENABLED = False

def __init__(self, *args, **kwargs):
super(CallbackModule, self).__init__(*args, **kwargs)

def v2_runner_on_ok(self, result):
fields = result._task_fields
if (
fields["action"] in ["package", "dnf", "yum"]
and fields["args"].get("state") != "absent"
):
packages = set()
if "invocation" in result._result:
results = [result._result]
elif "results" in result._result and isinstance(
result._result["results"], list
):
results = result._result["results"]
for item in results:

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable

Local variable 'results' may be used before it is initialized.

Copilot Autofix

AI 6 months ago

In general, to fix a “potentially uninitialized local variable” problem, either (1) initialize the variable to a safe default before any conditional assignments or (2) ensure all control-flow paths that reach its use have definitely assigned it (for example, by adding else cases or early returns).

Here, the safest change without altering existing behavior is:

  • Initialize results to an empty list before the if/elif chain.
  • After the chain, only iterate over results if it is non-empty; otherwise, simply skip the loop so no UnboundLocalError can occur.
    This preserves current behavior when results is defined as before, while making the code no-op (rather than crash) in the rare case that neither condition is met.

Concretely in tests/callback_plugins/dump_packages.py:

  • In CallbackModule.v2_runner_on_ok, add results = [] right after packages = set().
  • Wrap the for item in results: loop and subsequent package processing in an if results: guard so it only executes when results has been set to something meaningful.

No new imports or helper methods are required.

Suggested changeset 1
tests/callback_plugins/dump_packages.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/tests/callback_plugins/dump_packages.py b/tests/callback_plugins/dump_packages.py
--- a/tests/callback_plugins/dump_packages.py
+++ b/tests/callback_plugins/dump_packages.py
@@ -45,20 +45,22 @@
             and fields["args"].get("state") != "absent"
         ):
             packages = set()
+            results = []
             if "invocation" in result._result:
                 results = [result._result]
             elif "results" in result._result and isinstance(
                 result._result["results"], list
             ):
                 results = result._result["results"]
-            for item in results:
-                pkgs = item["invocation"]["module_args"]["name"]
-                if isinstance(pkgs, list):
-                    for ii in pkgs:
-                        packages.add(ii)
-                else:
-                    packages.add(pkgs)
-            # tell python black that this line is ok
-            # fmt: off
-            self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
-            # fmt: on
+            if results:
+                for item in results:
+                    pkgs = item["invocation"]["module_args"]["name"]
+                    if isinstance(pkgs, list):
+                        for ii in pkgs:
+                            packages.add(ii)
+                    else:
+                        packages.add(pkgs)
+                # tell python black that this line is ok
+                # fmt: off
+                self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
+                # fmt: on
EOF
@@ -45,20 +45,22 @@
and fields["args"].get("state") != "absent"
):
packages = set()
results = []
if "invocation" in result._result:
results = [result._result]
elif "results" in result._result and isinstance(
result._result["results"], list
):
results = result._result["results"]
for item in results:
pkgs = item["invocation"]["module_args"]["name"]
if isinstance(pkgs, list):
for ii in pkgs:
packages.add(ii)
else:
packages.add(pkgs)
# tell python black that this line is ok
# fmt: off
self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
# fmt: on
if results:
for item in results:
pkgs = item["invocation"]["module_args"]["name"]
if isinstance(pkgs, list):
for ii in pkgs:
packages.add(ii)
else:
packages.add(pkgs)
# tell python black that this line is ok
# fmt: off
self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
# fmt: on
Copilot is powered by AI and may make mistakes. Always verify output.
pkgs = item["invocation"]["module_args"]["name"]
if isinstance(pkgs, list):
for ii in pkgs:
packages.add(ii)
else:
packages.add(pkgs)
# tell python black that this line is ok
# fmt: off
self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
# fmt: on