Skip to content

[PW_SID:969513] clk: spacemit: mark K1 pll1_d8 as critical#483

Closed
linux-riscv-bot wants to merge 2 commits into
workflowfrom
pw969513
Closed

[PW_SID:969513] clk: spacemit: mark K1 pll1_d8 as critical#483
linux-riscv-bot wants to merge 2 commits into
workflowfrom
pw969513

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown

PR for series 969513 applied to workflow

Name: clk: spacemit: mark K1 pll1_d8 as critical
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=969513
Version: 1

Linux RISC-V bot and others added 2 commits June 7, 2025 19:16
Adding CI files
b94890f
@alexelder
clk: spacemit: mark K1 pll1_d8 as critical
00ada15 
The pll1_d8 clock is enabled by the boot loader, and is ultimately a
parent for numerous clocks.  Guodong Xu was recently testing DMA,
adding a reset property, and discovered that the needed reset was
not yet ready during initial probe.  It dropped its clock reference,
which dropped parent references, and along the way it dropped the sole
reference to pll1_d8 (from its prior clk_get()).  Clock pll1_d8 got
disabled, which resulted in a non-functioning system.

Mark that clock critical so it doesn't get turned off in this case.
We might be able to turn this flag off someday, but for now it
resolves the problem Guodong encountered.

Define a new macro CCU_FACTOR_GATE_DEFINE() to allow clock flags to
be supplied for a CCU_FACTOR_GATE clock.

Fixes: 1b72c59 ("clk: spacemit: Add clock support for SpacemiT K1 SoC")
Signed-off-by: Alex Elder <elder@riscstar.com>
Tested-by: Guodong Xu <guodong@riscstar.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 112.38 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 952.97 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1296.18 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 22.84 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 23.84 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.70 seconds
Result: WARNING
Output:

CHECK: Alignment should match open parenthesis
#40: FILE: drivers/clk/spacemit/ccu-k1.c:174:
+CCU_FACTOR_GATE_FLAGS_DEFINE(pll1_d8, CCU_PARENT_HW(pll1), APBS_PLL1_SWCR2, BIT(7), 8, 1,
+		CLK_IS_CRITICAL);

total: 0 errors, 0 warnings, 1 checks, 35 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 00ada1543ca3 ("clk: spacemit: mark K1 pll1_d8 as critical") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 1 checks, 35 lines checked
CHECK: Alignment should match open parenthesis

@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.37 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
kdoc
Desc: Detects for kdoc errors
Duration: 0.92 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 7, 2025

Copy link
Copy Markdown
Author

Patch 1: "clk: spacemit: mark K1 pll1_d8 as critical"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot force-pushed the workflow branch 2 times, most recently from e82ef7c to e65aa72 Compare June 8, 2025 21:17
@linux-riscv-bot
linux-riscv-bot deleted the pw969513 branch June 9, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @alexelder