[PW_SID:1129353] clk: spacemit: k3: fix i2s clock topology and divider rates by linux-riscv-bot · Pull Request #2302 · linux-riscv/linux

linux-riscv-bot · 2026-07-17T09:34:02Z

PR for series 1129353 applied to workflow__riscv__fixes

Name: clk: spacemit: k3: fix i2s clock topology and divider rates
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1129353
Version: 1

…2s1_sysclk_src IDs Add three new clock IDs to expose clocks introduced by the topology fix: - CLK_MPMU_I2S_SYSCLK (51): the common i2s sysclk DDN at MPMU_ISCCR1 - CLK_MPMU_I2S_BCLK_FACTOR (52): the implicit /2 factor feeding i2s_bclk - CLK_MPMU_I2S1_SYSCLK_SRC (53): the dedicated i2s1 sysclk source mux CLK_MPMU_I2S1_SYSCLK keeps its existing ID (47) but will be repointed to the real per-instance i2s1 clock in a subsequent patch. No in-tree user references this ID so the semantic change is contained. Fixes: efe897b ("dt-bindings: soc: spacemit: k3: add clock support") Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The K3 i2s clocks were modelled as a single path behind one MPMU register: pll1_d96_25p6 / i2s_153p6_base `-- i2s_sysclk_src (mux+gate, MPMU_ISCCR) `-- i2s1_sysclk (DDN, MPMU_ISCCR) |-- i2s_bclk (div+gate, MPMU_ISCCR) `-- i2s2_sysclk (mux, parent 0) The hardware actually has two i2s clock control registers, ISCCR0 (0x0040) and ISCCR1 (0x0044): ISCCR1 drives the common sysclk shared by i2s0/2/3/4/5 and the common bclk, whose divider always implies a fixed 1/2 factor in front, while ISCCR0 drives a dedicated path for i2s1: pll1_d96_25p6 / i2s_153p6_base |-- i2s_sysclk_src (mux+gate, MPMU_ISCCR1) | `-- i2s_sysclk (DDN, MPMU_ISCCR1) | |-- i2s_bclk_factor (fixed factor, /2) | | `-- i2s_bclk (div+gate, MPMU_ISCCR1) | `-- i2s2_sysclk (mux, parent 0) `-- i2s1_sysclk_src (mux+gate, MPMU_ISCCR0) `-- i2s1_sysclk (DDN, MPMU_ISCCR0) Because of this mismatch, i2s_bclk reported twice the real rate, and the dedicated i2s1 clock path could not be described in DT at all. Model the tree as above: split the MPMU_ISCCR register macro into MPMU_ISCCR0 and MPMU_ISCCR1 to match the hardware register names, rename the common DDN to i2s_sysclk, insert the fixed 1/2 factor i2s_bclk_factor in front of i2s_bclk, and add the i2s1_sysclk_src mux and i2s1_sysclk DDN backed by MPMU_ISCCR0. CLK_MPMU_I2S1_SYSCLK now refers to the dedicated i2s1 clock; no in-tree user references this ID, so nothing is affected by the change of meaning. Fixes: e371a77 ("clk: spacemit: k3: add the clock tree") Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The i2s{0,2,3,4,5}_sysclk_div DDNs have an additional fixed 1/2 divider in the hardware IP after the configurable divider, so the real output rate is: rate = parent_rate * num / (den * 2) Set pre_div to 2 to account for it. Fixes: e371a77 ("clk: spacemit: k3: add the clock tree") Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2026-07-17T09:39:29Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 119.78 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:02:28Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1377.66 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:28:37Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1566.51 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:28:59Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.89 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:29:23Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.83 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:29:25Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.64 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:30:50Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.58 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:30:52Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:30:54Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
kdoc
Desc: Detects for kdoc errors
Duration: 0.73 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:30:56Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:30:58Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:31:00Z

Patch 1: "[1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:33:16Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 119.22 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T10:52:34Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1156.21 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T11:16:59Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1463.54 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T11:17:21Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.72 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T11:17:45Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.62 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T11:17:48Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.83 seconds
Result: WARNING
Output:

CHECK: Please use a blank line after function/struct/union/enum declarations
#58: FILE: drivers/clk/spacemit/ccu-k3.c:221:
 };
+CCU_MUX_GATE_DEFINE(i2s_sysclk_src, i2s_sysclk_src_parents, MPMU_ISCCR1, 30, 1, BIT(31), 0);

total: 0 errors, 0 warnings, 1 checks, 51 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 00b09086368d ("clk: spacemit: k3: fix i2s clock topology") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 1 checks, 51 lines checked
CHECK: Please use a blank line after function/struct/union/enum declarations

linux-riscv-bot · 2026-07-17T11:19:13Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 82.98 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T11:19:14Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T11:19:16Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
kdoc
Desc: Detects for kdoc errors
Duration: 0.73 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T11:19:18Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T11:19:20Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.76 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T11:19:22Z

Patch 2: "[2/3] clk: spacemit: k3: fix i2s clock topology"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.27 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T11:21:37Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 119.12 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T11:40:55Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1156.57 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T12:05:02Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1444.84 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T12:05:24Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.23 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T12:05:47Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.86 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T12:05:50Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.64 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T12:07:15Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.39 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T12:07:17Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T12:07:19Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
kdoc
Desc: Detects for kdoc errors
Duration: 0.72 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T12:07:21Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T12:07:23Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

linux-riscv-bot · 2026-07-17T12:07:24Z

Patch 3: "[3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.26 seconds
Result: PASS

Linux RISC-V bot and others added 4 commits July 15, 2026 17:25

Adding CI files

8ca72ef

linux-riscv-bot force-pushed the workflow__riscv__fixes branch from 8ca72ef to 60e0882 Compare July 19, 2026 17:58

linux-riscv-bot closed this Jul 19, 2026

linux-riscv-bot deleted the pw1129353 branch July 19, 2026 17:58

Uh oh!

Conversation

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

linux-riscv-bot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects