[PW_SID:1124035] mm/early_ioremap: clarify and clean up early_ioremap_reset()#2246
[PW_SID:1124035] mm/early_ioremap: clarify and clean up early_ioremap_reset()#2246linux-riscv-bot wants to merge 4 commits into
Conversation
__late_set_fixmap() and __late_clear_fixmap() are only used after
early_ioremap_reset() has been called.
arm64, riscv and powerpc all have a __set_fixmap() that works before
and after paging_init(), so they do not need to call
early_ioremap_reset() or define the macros, but they describe the same
situation in three different ways:
calls reset defines the macros
arm64 yes yes
riscv no yes
powerpc no no
The existing comment is vague and allows all three. Replace it with
comments that make it clear when the reset and the macros are needed.
No functional change.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
__late_set_fixmap() and __late_clear_fixmap() are only used after early_ioremap_reset() has been called. riscv never calls it because __set_fixmap() works before and after paging_init(). So remove them. No functional change. Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
On arm64, __early_set_fixmap(), __late_set_fixmap() and __late_clear_fixmap() are all __set_fixmap(). Calling early_ioremap_reset() changes nothing. So remove the call and the macros. No functional change. Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 1: "[1/3] mm/early_ioremap: clarify early_ioremap_reset() semantics" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 2: "[2/3] riscv: remove unused __late_set_fixmap() and __late_clear_fixmap()" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
|
Patch 3: "[3/3] arm64: remove early_ioremap_reset() call and _late* macros" |
56b6f30 to
8ca72ef
Compare
PR for series 1124035 applied to workflow__riscv__fixes
Name: mm/early_ioremap: clarify and clean up early_ioremap_reset()
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1124035
Version: 1