Skip to content

[PW_SID:1119369] riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug#2180

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1119369
Closed

[PW_SID:1119369] riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug#2180
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1119369

Conversation

@linux-riscv-bot

Copy link
Copy Markdown

PR for series 1119369 applied to workflow__riscv__fixes

Name: riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1119369
Version: 1

Linux RISC-V bot and others added 2 commits July 1, 2026 03:48
When a CPU receives an IPI stop during hotplug teardown, the
platform-specific cpu_stop() callback should be called before
spinning in wait_for_interrupt(), so that firmware (e.g. SBI HSM)
is notified that the hart has stopped.

This aligns ipi_stop() with the existing behavior of
ipi_cpu_crash_stop(), which already calls cpu_ops[cpu]->cpu_stop()
under CONFIG_HOTPLUG_CPU.

Signed-off-by: Guo Ren (Alibaba DAMO Academy) <guoren@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 108.36 seconds
Result: ERROR
Output:

Full log:
W: Support for running offline not available (unshare: unshare failed: Operation not permitted)
I: config: PASS in 0:00:16.476553
I: default: FAIL in 0:01:24.686619
I: kernel: SKIP in 0:00:00.000006
I: xipkernel: SKIP in 0:00:00.000003
I: modules: FAIL in 0:00:00.051448
I: dtbs: PASS in 0:00:01.721549
I: dtbs-legacy: SKIP in 0:00:00.002246
I: debugkernel: SKIP in 0:00:00.000002
I: headers: PASS in 0:00:00.903833
I: build output in /build/tmp.yS2oo2RQAz
tuxmake --download-all-korg-gcc-toolchains --target-arch=riscv --kconfig=rv32_defconfig --toolchain=llvm --wrapper=ccache --environment=KBUILD_BUILD_TIMESTAMP=@1621270510 --environment=KBUILD_BUILD_USER=tuxmake --environment=KBUILD_BUILD_HOST=tuxmake --environment=KCFLAGS=-ffile-prefix-map=/build/tmp.yS2oo2RQAz/build/= --runtime=null --image=docker.io/tuxmake/riscv_clang CROSS_COMPILE=riscv64-linux- config default kernel xipkernel modules dtbs dtbs-legacy debugkernel headers
make --silent --keep-going --jobs=48 O=/build/tmp.yS2oo2RQAz/build ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang' rv32_defconfig
make --silent --keep-going --jobs=48 O=/build/tmp.yS2oo2RQAz/build ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang'
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c:87:22: error: use of undeclared identifier 'cpu'
   87 |         if (cpu_has_hotplug(cpu))
      |                             ^
1 error generated.
make[5]: *** [/build/tmp4wxxmvb8/scripts/Makefile.build:289: arch/riscv/kernel/smp.o] Error 1
make[5]: Target 'arch/riscv/kernel/' not remade because of errors.
make[4]: *** [/build/tmp4wxxmvb8/scripts/Makefile.build:549: arch/riscv/kernel] Error 2
make[4]: Target 'arch/riscv/' not remade because of errors.
make[3]: *** [/build/tmp4wxxmvb8/scripts/Makefile.build:549: arch/riscv] Error 2
make[3]: Target './' not remade because of errors.
make[2]: *** [/build/tmp4wxxmvb8/Makefile:2184: .] Error 2
make[2]: Target '__all' not remade because of errors.
make[1]: *** [/build/tmp4wxxmvb8/Makefile:248: __sub-make] Error 2
make[1]: Target '__all' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target '__all' not remade because of errors.
rm -rf /build/tmp.yS2oo2RQAz/build/modinstall
make --silent --keep-going --jobs=48 O=/build/tmp.yS2oo2RQAz/build INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=/build/tmp.yS2oo2RQAz/build/modinstall ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang' modules_install
make[3]: *** No rule to make target 'modules.order', needed by '/build/tmp.yS2oo2RQAz/build/modinstall/lib/modules/7.1.0-13680-g563e1c84775c/modules.order'.
make[3]: *** No rule to make target 'modules.builtin', needed by '/build/tmp.yS2oo2RQAz/build/modinstall/lib/modules/7.1.0-13680-g563e1c84775c/modules.builtin'.
make[3]: *** No rule to make target 'modules.builtin.modinfo', needed by '/build/tmp.yS2oo2RQAz/build/modinstall/lib/modules/7.1.0-13680-g563e1c84775c/modules.builtin.modinfo'.
make[3]: Target '__modinst' not remade because of errors.
make[2]: *** [/build/tmp4wxxmvb8/Makefile:2090: modules_install] Error 2
make[1]: *** [/build/tmp4wxxmvb8/Makefile:248: __sub-make] Error 2
make[1]: Target 'modules_install' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target 'modules_install' not remade because of errors.
make --silent --keep-going --jobs=48 O=/build/tmp.yS2oo2RQAz/build INSTALL_DTBS_PATH=/build/tmp.yS2oo2RQAz/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang' dtbs
rm -rf /build/tmp.yS2oo2RQAz/build/dtbsinstall
mkdir -p /build/tmp.yS2oo2RQAz/build/dtbsinstall/dtbs
make --silent --keep-going --jobs=48 O=/build/tmp.yS2oo2RQAz/build INSTALL_DTBS_PATH=/build/tmp.yS2oo2RQAz/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang' dtbs_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1782877753 --clamp-mtime -caf /build/tmp.yS2oo2RQAz/build/dtbs.tar -C /build/tmp.yS2oo2RQAz/build/dtbsinstall dtbs
rm -rf /build/tmp.yS2oo2RQAz/build/install_hdr
make --silent --keep-going --jobs=48 O=/build/tmp.yS2oo2RQAz/build INSTALL_HDR_PATH=/build/tmp.yS2oo2RQAz/build/install_hdr/ ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang' headers_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1782877753 --clamp-mtime -caf /build/tmp.yS2oo2RQAz/build/headers.tar -C /build/tmp.yS2oo2RQAz/build/install_hdr .
warnings/errors:
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c:87:22: error: use of undeclared identifier 'cpu'


@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 789.99 seconds
Result: ERROR
Output:

Redirect to /build/tmp.mJowlYtZSu and /build/tmp.FdLUg94NqY
Tree base:
89be0ce560195 ("Adding CI files")
Building the whole tree with the patch
error:
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c:87:22: error: use of undeclared identifier 'cpu'



real	13m1.302s
user	507m23.551s
sys	96m45.038s

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1051.78 seconds
Result: ERROR
Output:

Redirect to /build/tmp.bUnp7ZtyZ8 and /build/tmp.7gkELMszab
Tree base:
89be0ce560195 ("Adding CI files")
Building the whole tree with the patch
error:
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c:87:29: error: 'cpu' undeclared (first use in this function)



real	17m25.111s
user	685m41.504s
sys	115m50.189s

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.10 seconds
Result: ERROR
Output:

Full log:
W: Support for running offline not available (unshare: unshare failed: Operation not permitted)
I: config: PASS in 0:00:02.485542
I: default: FAIL in 0:00:13.151920
I: kernel: SKIP in 0:00:00.000007
I: xipkernel: SKIP in 0:00:00.000002
I: modules: SKIP in 0:00:00.001508
I: dtbs: PASS in 0:00:01.421234
I: dtbs-legacy: SKIP in 0:00:00.002037
I: debugkernel: SKIP in 0:00:00.000002
I: headers: PASS in 0:00:00.971460
I: build output in /build/tmp.ty3RIl19nK
tuxmake --download-all-korg-gcc-toolchains --target-arch=riscv --kconfig=nommu_k210_defconfig --toolchain=gcc --wrapper=ccache --environment=KBUILD_BUILD_TIMESTAMP=@1621270510 --environment=KBUILD_BUILD_USER=tuxmake --environment=KBUILD_BUILD_HOST=tuxmake --environment=KCFLAGS=-ffile-prefix-map=/build/tmp.ty3RIl19nK/build/= --runtime=null --image=docker.io/tuxmake/riscv_gcc CROSS_COMPILE=riscv64-linux- config default kernel xipkernel modules dtbs dtbs-legacy debugkernel headers
make --silent --keep-going --jobs=48 O=/build/tmp.ty3RIl19nK/build ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' nommu_k210_defconfig
make --silent --keep-going --jobs=48 O=/build/tmp.ty3RIl19nK/build ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc'
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c: In function 'ipi_stop':
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c:87:29: error: 'cpu' undeclared (first use in this function)
   87 |         if (cpu_has_hotplug(cpu))
      |                             ^~~
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c:87:29: note: each undeclared identifier is reported only once for each function it appears in
make[5]: *** [/build/tmp4wxxmvb8/scripts/Makefile.build:289: arch/riscv/kernel/smp.o] Error 1
make[5]: Target 'arch/riscv/kernel/' not remade because of errors.
make[4]: *** [/build/tmp4wxxmvb8/scripts/Makefile.build:549: arch/riscv/kernel] Error 2
make[4]: Target 'arch/riscv/' not remade because of errors.
make[3]: *** [/build/tmp4wxxmvb8/scripts/Makefile.build:549: arch/riscv] Error 2
make[3]: Target './' not remade because of errors.
make[2]: *** [/build/tmp4wxxmvb8/Makefile:2184: .] Error 2
make[2]: Target '__all' not remade because of errors.
make[1]: *** [/build/tmp4wxxmvb8/Makefile:248: __sub-make] Error 2
make[1]: Target '__all' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target '__all' not remade because of errors.
make --silent --keep-going --jobs=48 O=/build/tmp.ty3RIl19nK/build INSTALL_DTBS_PATH=/build/tmp.ty3RIl19nK/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' dtbs
rm -rf /build/tmp.ty3RIl19nK/build/dtbsinstall
mkdir -p /build/tmp.ty3RIl19nK/build/dtbsinstall/dtbs
make --silent --keep-going --jobs=48 O=/build/tmp.ty3RIl19nK/build INSTALL_DTBS_PATH=/build/tmp.ty3RIl19nK/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' dtbs_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1782877753 --clamp-mtime -caf /build/tmp.ty3RIl19nK/build/dtbs.tar -C /build/tmp.ty3RIl19nK/build/dtbsinstall dtbs
rm -rf /build/tmp.ty3RIl19nK/build/install_hdr
make --silent --keep-going --jobs=48 O=/build/tmp.ty3RIl19nK/build INSTALL_HDR_PATH=/build/tmp.ty3RIl19nK/build/install_hdr/ ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' headers_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1782877753 --clamp-mtime -caf /build/tmp.ty3RIl19nK/build/headers.tar -C /build/tmp.ty3RIl19nK/build/install_hdr .
warnings/errors:
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c:87:29: error: 'cpu' undeclared (first use in this function)


@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.54 seconds
Result: ERROR
Output:

Full log:
W: Support for running offline not available (unshare: unshare failed: Operation not permitted)
I: config: PASS in 0:00:02.482951
I: default: FAIL in 0:00:14.473054
I: kernel: SKIP in 0:00:00.000006
I: xipkernel: SKIP in 0:00:00.000003
I: modules: SKIP in 0:00:00.001453
I: dtbs: PASS in 0:00:01.471671
I: dtbs-legacy: SKIP in 0:00:00.002162
I: debugkernel: SKIP in 0:00:00.000003
I: headers: PASS in 0:00:01.006835
I: build output in /build/tmp.pwcqPiM6eq
tuxmake --download-all-korg-gcc-toolchains --target-arch=riscv --kconfig=nommu_virt_defconfig --toolchain=gcc --wrapper=ccache --environment=KBUILD_BUILD_TIMESTAMP=@1621270510 --environment=KBUILD_BUILD_USER=tuxmake --environment=KBUILD_BUILD_HOST=tuxmake --environment=KCFLAGS=-ffile-prefix-map=/build/tmp.pwcqPiM6eq/build/= --runtime=null --image=docker.io/tuxmake/riscv_gcc CROSS_COMPILE=riscv64-linux- config default kernel xipkernel modules dtbs dtbs-legacy debugkernel headers
make --silent --keep-going --jobs=48 O=/build/tmp.pwcqPiM6eq/build ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' nommu_virt_defconfig
make --silent --keep-going --jobs=48 O=/build/tmp.pwcqPiM6eq/build ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc'
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c: In function 'ipi_stop':
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c:87:29: error: 'cpu' undeclared (first use in this function)
   87 |         if (cpu_has_hotplug(cpu))
      |                             ^~~
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c:87:29: note: each undeclared identifier is reported only once for each function it appears in
make[5]: *** [/build/tmp4wxxmvb8/scripts/Makefile.build:289: arch/riscv/kernel/smp.o] Error 1
make[5]: Target 'arch/riscv/kernel/' not remade because of errors.
make[4]: *** [/build/tmp4wxxmvb8/scripts/Makefile.build:549: arch/riscv/kernel] Error 2
make[4]: Target 'arch/riscv/' not remade because of errors.
make[3]: *** [/build/tmp4wxxmvb8/scripts/Makefile.build:549: arch/riscv] Error 2
make[3]: Target './' not remade because of errors.
make[2]: *** [/build/tmp4wxxmvb8/Makefile:2184: .] Error 2
make[2]: Target '__all' not remade because of errors.
make[1]: *** [/build/tmp4wxxmvb8/Makefile:248: __sub-make] Error 2
make[1]: Target '__all' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target '__all' not remade because of errors.
make --silent --keep-going --jobs=48 O=/build/tmp.pwcqPiM6eq/build INSTALL_DTBS_PATH=/build/tmp.pwcqPiM6eq/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' dtbs
rm -rf /build/tmp.pwcqPiM6eq/build/dtbsinstall
mkdir -p /build/tmp.pwcqPiM6eq/build/dtbsinstall/dtbs
make --silent --keep-going --jobs=48 O=/build/tmp.pwcqPiM6eq/build INSTALL_DTBS_PATH=/build/tmp.pwcqPiM6eq/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' dtbs_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1782877753 --clamp-mtime -caf /build/tmp.pwcqPiM6eq/build/dtbs.tar -C /build/tmp.pwcqPiM6eq/build/dtbsinstall dtbs
rm -rf /build/tmp.pwcqPiM6eq/build/install_hdr
make --silent --keep-going --jobs=48 O=/build/tmp.pwcqPiM6eq/build INSTALL_HDR_PATH=/build/tmp.pwcqPiM6eq/build/install_hdr/ ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' headers_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1782877753 --clamp-mtime -caf /build/tmp.pwcqPiM6eq/build/headers.tar -C /build/tmp.pwcqPiM6eq/build/install_hdr .
warnings/errors:
/build/tmp4wxxmvb8/arch/riscv/kernel/smp.c:87:29: error: 'cpu' undeclared (first use in this function)


@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.64 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.78 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
kdoc
Desc: Detects for kdoc errors
Duration: 0.73 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
module-param
Desc: Detect module_param changes
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "riscv: smp: Invoke cpu_ops->cpu_stop() in ipi_stop() for hotplug"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.92 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot force-pushed the workflow__riscv__fixes branch 3 times, most recently from a50938c to 40ba5ca Compare July 8, 2026 17:32
@linux-riscv-bot
linux-riscv-bot deleted the pw1119369 branch July 9, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants