[PW_SID:1118797] [v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe() by linux-riscv-bot · Pull Request #2175 · linux-riscv/linux

linux-riscv-bot · 2026-06-30T10:34:21Z

PR for series 1118797 applied to workflow__riscv__fixes

Name: [v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1118797
Version: 4

The fp_is_valid() function uses ALIGN(sp, THREAD_SIZE) as the upper bound for the frame pointer check. This bound is calculated relative to the current sp and shifts upward when sp itself exceeds the valid stack region, allowing the unwinder to read past the end of the allocated task stack and triggering KASAN stack-out-of-bounds. Fix this by using absolute stack boundaries determined once before the unwind loop: - When sp is on the task stack, use the task's pt_regs as the upper bound. - When sp is on the overflow_stack (CONFIG_VMAP_STACK=y), use the overflow_stack's top as the boundary. - When sp is on the IRQ stack (CONFIG_IRQ_STACKS=y), use the IRQ stack's top as the boundary. - When sp is not on any known stack, warn and return. - For remote tasks (task != current), if sp is not on the task stack, warn and return since we cannot reliably determine the correct boundary from a different CPU's stacks. Fixes: a2a4d4a ("riscv: stacktrace: fixed walk_stackframe()") Signed-off-by: Jiakai Xu <xujiakai2025@iscas.ac.cn> Assisted-by: YuanSheng:DeepSeek-V3.2 Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2026-06-30T14:27:48Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 150.90 seconds
Result: PASS

linux-riscv-bot · 2026-06-30T14:51:47Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1437.84 seconds
Result: PASS

linux-riscv-bot · 2026-06-30T15:20:48Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1739.25 seconds
Result: PASS

linux-riscv-bot · 2026-06-30T15:21:20Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 29.66 seconds
Result: PASS

linux-riscv-bot · 2026-06-30T15:21:52Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 30.77 seconds
Result: PASS

linux-riscv-bot · 2026-06-30T15:21:56Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.19 seconds
Result: WARNING
Output:

CHECK: Alignment should match open parenthesis
#53: FILE: arch/riscv/kernel/stacktrace.c:40:
+static inline int fp_is_valid(unsigned long fp, unsigned long sp,
+			       unsigned long high)

CHECK: Unbalanced braces around else statement
#88: FILE: arch/riscv/kernel/stacktrace.c:84:
+	else {

CHECK: Unnecessary parentheses around 'regs->epc == pc'
#123: FILE: arch/riscv/kernel/stacktrace.c:117:
+		if (regs && (regs->epc == pc) && fp_is_valid(frame->ra, sp, high)) {

total: 0 errors, 0 warnings, 3 checks, 84 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 8522811ea8bc ("riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 3 checks, 84 lines checked
CHECK: Alignment should match open parenthesis
CHECK: Unbalanced braces around else statement
CHECK: Unnecessary parentheses around 'regs->epc == pc'

linux-riscv-bot · 2026-06-30T15:23:24Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 86.20 seconds
Result: PASS

linux-riscv-bot · 2026-06-30T15:23:26Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.42 seconds
Result: PASS

linux-riscv-bot · 2026-06-30T15:23:28Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
kdoc
Desc: Detects for kdoc errors
Duration: 1.07 seconds
Result: PASS

linux-riscv-bot · 2026-06-30T15:23:30Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
module-param
Desc: Detect module_param changes
Duration: 0.44 seconds
Result: PASS

linux-riscv-bot · 2026-06-30T15:23:32Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.53 seconds
Result: PASS

linux-riscv-bot · 2026-06-30T15:23:35Z

Patch 1: "[v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.46 seconds
Result: PASS

Linux RISC-V bot and others added 2 commits June 25, 2026 20:36

Adding CI files

4d827ba

linux-riscv-bot force-pushed the workflow__riscv__fixes branch from 4d827ba to 89be0ce Compare July 1, 2026 03:48

linux-riscv-bot closed this Jul 5, 2026

linux-riscv-bot deleted the pw1118797 branch July 5, 2026 08:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PW_SID:1118797] [v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()#2175

[PW_SID:1118797] [v4] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe()#2175
linux-riscv-bot wants to merge 2 commits into
workflowriscvfixesfrom
pw1118797

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

linux-riscv-bot commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants