Skip to content

[PW_SID:1118146] net: stmmac: qcom-ethqos: add support for SCMI power domains#2161

Closed
linux-riscv-bot wants to merge 8 commits into
workflow__riscv__fixesfrom
pw1118146
Closed

[PW_SID:1118146] net: stmmac: qcom-ethqos: add support for SCMI power domains#2161
linux-riscv-bot wants to merge 8 commits into
workflow__riscv__fixesfrom
pw1118146

Conversation

@linux-riscv-bot

Copy link
Copy Markdown

PR for series 1118146 applied to workflow__riscv__fixes

Name: net: stmmac: qcom-ethqos: add support for SCMI power domains
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1118146
Version: 11

Linux RISC-V bot and others added 8 commits June 25, 2026 20:36
Describe the SGMII/SerDes PHY present on the Qualcomm sa8255p platforms.
This is essentially the same hardware as sa8775p rev3 but the PHY is
managed by firmware over SCMI.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Implement support for the firmware-managed SGMII/SerDes PHY present on
Qualcomm platforms. Do this as a separate driver from the HLOS-managed
variant as they don't share almost any code.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
…tems

Describe the firmware-managed variant of the QCom DesignWare MAC. As the
properties here differ a lot from the HLOS-managed variant, lets put it
in a separate file. Since we need to update the maximum number of power
domains, let's update existing bindings referencing the top-level
snps,dwmac.yaml and limit their maxItems for power-domains to 1.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Call phy_set_mode_ext() before phy_power_on() in
qcom_ethqos_serdes_powerup(). This is harmless for existing users but on
SCMI systems this is required for the PHY driver to select the right
performance level - which translates to the link speed. This is done
ahead of adding support for the firmware-managed EMAC on Qualcomm sa8255p.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Instead of needlessly copying the fields of ethqos_emac_driver_data into
struct qcom_ethqos, just use the address of the former as a reference.
It's .rodata after all. This is done in order to avoid having either two
calls to of_device_get_match_data() or having to extend the latter with
another field when adding support for SCMI.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
…e function

Ahead of adding support for firmware-controlled EMAC variants, extend
the ethqos_emac_driver_data structure with a setup() callback, implement
it for the existing models and move all operations not required in SCMI
mode into it.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Extend the driver to support a new model - sa8255p. Unlike the previously
supported variants, this one's power management is done in the firmware
over SCMI. This is modeled in linux using power domains so add a new
emac data variant and a separate setup callback.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 119.84 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1107.82 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1410.07 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.88 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 23.25 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.76 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 51 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 992c4d068180 ("dt-bindings: phy: document the serdes PHY on sa8255p") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 51 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 79.39 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.43 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
kdoc
Desc: Detects for kdoc errors
Duration: 0.81 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
module-param
Desc: Detect module_param changes
Duration: 0.40 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.45 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v11,1/7] dt-bindings: phy: document the serdes PHY on sa8255p"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.43 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v11,2/7] phy: qcom: add the SGMII SerDes PHY driver for SCMI systems"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 120.19 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v11,2/7] phy: qcom: add the SGMII SerDes PHY driver for SCMI systems"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1144.57 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v11,2/7] phy: qcom: add the SGMII SerDes PHY driver for SCMI systems"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1453.41 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v11,2/7] phy: qcom: add the SGMII SerDes PHY driver for SCMI systems"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 22.24 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v11,2/7] phy: qcom: add the SGMII SerDes PHY driver for SCMI systems"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 23.56 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v11,2/7] phy: qcom: add the SGMII SerDes PHY driver for SCMI systems"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.22 seconds
Result: WARNING
Output:

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#28: FILE: drivers/phy/qualcomm/Kconfig:236:
+config PHY_QCOM_SGMII_ETH_SCMI
+	tristate "Qualcomm DWMAC SGMII SerDes/PHY driver (firmware managed)"
+	depends on OF && (ARCH_QCOM || COMPILE_TEST)
+	select GENERIC_PHY
+	select PM_GENERIC_DOMAINS
+	help
+	  Enable this to support the internal SerDes/SGMII PHY on Qualcomm
+	  chipsets where the SerDes hardware (clocks and registers) is owned
+	  by the firmware.

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 2 warnings, 0 checks, 178 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 698084ebb7fa ("phy: qcom: add the SGMII SerDes PHY driver for SCMI systems") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 0 checks, 178 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines


@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v11,2/7] phy: qcom: add the SGMII SerDes PHY driver for SCMI systems"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 78.72 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v11,2/7] phy: qcom: add the SGMII SerDes PHY driver for SCMI systems"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.47 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v11,2/7] phy: qcom: add the SGMII SerDes PHY driver for SCMI systems"
kdoc
Desc: Detects for kdoc errors
Duration: 0.97 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v11,2/7] phy: qcom: add the SGMII SerDes PHY driver for SCMI systems"
module-param
Desc: Detect module_param changes
Duration: 0.42 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v11,5/7] net: stmmac: qcom-ethqos: reuse the address of ethqos_emac_driver_data"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v11,5/7] net: stmmac: qcom-ethqos: reuse the address of ethqos_emac_driver_data"
module-param
Desc: Detect module_param changes
Duration: 0.45 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v11,5/7] net: stmmac: qcom-ethqos: reuse the address of ethqos_emac_driver_data"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.44 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v11,5/7] net: stmmac: qcom-ethqos: reuse the address of ethqos_emac_driver_data"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.41 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 6: "[net-next,v11,6/7] net: stmmac: qcom-ethqos: factor out linux-level setup into a separate function"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 120.59 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 6: "[net-next,v11,6/7] net: stmmac: qcom-ethqos: factor out linux-level setup into a separate function"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1149.36 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 6: "[net-next,v11,6/7] net: stmmac: qcom-ethqos: factor out linux-level setup into a separate function"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1435.04 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 6: "[net-next,v11,6/7] net: stmmac: qcom-ethqos: factor out linux-level setup into a separate function"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 22.00 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 6: "[net-next,v11,6/7] net: stmmac: qcom-ethqos: factor out linux-level setup into a separate function"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 23.56 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 6: "[net-next,v11,6/7] net: stmmac: qcom-ethqos: factor out linux-level setup into a separate function"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.76 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 6: "[net-next,v11,6/7] net: stmmac: qcom-ethqos: factor out linux-level setup into a separate function"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 79.63 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 6: "[net-next,v11,6/7] net: stmmac: qcom-ethqos: factor out linux-level setup into a separate function"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.47 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 6: "[net-next,v11,6/7] net: stmmac: qcom-ethqos: factor out linux-level setup into a separate function"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 6: "[net-next,v11,6/7] net: stmmac: qcom-ethqos: factor out linux-level setup into a separate function"
module-param
Desc: Detect module_param changes
Duration: 0.36 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 6: "[net-next,v11,6/7] net: stmmac: qcom-ethqos: factor out linux-level setup into a separate function"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.38 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 119.12 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1145.79 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1430.10 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 22.02 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 23.66 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 78.20 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.38 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
module-param
Desc: Detect module_param changes
Duration: 0.44 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.47 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 7: "[net-next,v11,7/7] net: stmmac: qcom-ethqos: add support for sa8255p"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.55 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot force-pushed the workflow__riscv__fixes branch from 4d827ba to 89be0ce Compare July 1, 2026 03:48
@linux-riscv-bot
linux-riscv-bot deleted the pw1118146 branch July 1, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants