libqcdm/commands: Fix null pointer dereference risks in memory allocation#28
Open
wxmzy88 wants to merge 1 commit into
Open
libqcdm/commands: Fix null pointer dereference risks in memory allocation#28wxmzy88 wants to merge 1 commit into
wxmzy88 wants to merge 1 commit into
Conversation
…tion Problem: Two potential null pointer dereference issues exist in code: 1)Direct access to array pointer without checking malloc return value in log_config_get_set_result 2)Access struct member directly without validating calloc result in qcdm_cmd_log_config_new Solution: Add NULL check after malloc allocation, return unified error code QCDM_ERROR_RESPONSE_FAILED when memory allocation fails, release created resource before return. Use internal macro qcdm_return_val_if_fail to verify calloc pointer validity, return 0 as failure result conforming existing code style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Two potential null pointer dereference issues exist in code:
1)Direct access to array pointer without checking malloc return value in log_config_get_set_result
2)Access struct member directly without validating calloc result in qcdm_cmd_log_config_new
Solution:
Add NULL check after malloc allocation, return unified error code QCDM_ERROR_RESPONSE_FAILED when memory allocation fails, release created resource before return. Use internal macro qcdm_return_val_if_fail to verify calloc pointer validity, return 0 as failure result conforming existing code style.