Skip to content

loop: serialize backing file swaps with sysfs readers #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blktests-ci wants to merge 1 commit into
base: linus-master_base
Choose a base branch
from
+8 −1
Open

loop: serialize backing file swaps with sysfs readers #993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion drivers/block/loop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,11 +503,18 @@ static int loop_validate_file(struct file *file, struct block_device *bdev)

static void loop_assign_backing_file(struct loop_device *lo, struct file *file)
{
/*
* Serialize the pointer update with sysfs backing_file show, which
* formats the file path under lo_lock without taking a file reference.
*/
spin_lock_irq(&lo->lo_lock);
lo->lo_backing_file = file;
spin_unlock_irq(&lo->lo_lock);

lo->old_gfp_mask = mapping_gfp_mask(file->f_mapping);
mapping_set_gfp_mask(file->f_mapping,
lo->old_gfp_mask & ~(__GFP_IO | __GFP_FS));
if (lo->lo_backing_file->f_flags & O_DIRECT)
if (file->f_flags & O_DIRECT)
lo->lo_flags |= LO_FLAGS_DIRECT_IO;
lo->lo_min_dio_size = loop_query_min_dio_size(lo);
}
Expand Down
Loading