Skip to content

block: rename need_dispatch to cautious_dispatch in blk-mq sched#887

Open
blktests-ci[bot] wants to merge 1 commit into
linus-master_basefrom
series/1100976=>linus-master
Open

block: rename need_dispatch to cautious_dispatch in blk-mq sched#887
blktests-ci[bot] wants to merge 1 commit into
linus-master_basefrom
series/1100976=>linus-master

Conversation

@blktests-ci

@blktests-ci blktests-ci Bot commented May 26, 2026

Copy link
Copy Markdown

Pull request for series with
subject: block: rename need_dispatch to cautious_dispatch in blk-mq sched
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1100976

@blktests-ci

blktests-ci Bot commented May 26, 2026

Copy link
Copy Markdown
Author

Upstream branch: eed108e
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from de94ac7 to 86d8d37 Compare May 26, 2026 15:37
@blktests-ci

blktests-ci Bot commented May 26, 2026

Copy link
Copy Markdown
Author

Upstream branch: e8c2f9f
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from a7d2e76 to def1d24 Compare May 26, 2026 15:53
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 86d8d37 to 9805659 Compare May 28, 2026 13:24
@blktests-ci

blktests-ci Bot commented May 28, 2026

Copy link
Copy Markdown
Author

Upstream branch: eb3f4b7
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from def1d24 to 88e85dc Compare May 28, 2026 13:40
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 9805659 to 3f4a345 Compare May 29, 2026 11:12
@blktests-ci

blktests-ci Bot commented May 29, 2026

Copy link
Copy Markdown
Author

Upstream branch: 8fde5d1
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from 88e85dc to 171151b Compare May 29, 2026 11:28
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 3f4a345 to c6dc343 Compare June 1, 2026 08:57
@blktests-ci

blktests-ci Bot commented Jun 1, 2026

Copy link
Copy Markdown
Author

Upstream branch: e43ffb6
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from 171151b to c4c23a9 Compare June 1, 2026 09:14
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from c6dc343 to fc36596 Compare June 3, 2026 13:56
@blktests-ci

blktests-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Author

Upstream branch: ba3e43a
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from c4c23a9 to 41a85d9 Compare June 3, 2026 14:30
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from fc36596 to 7bed9c3 Compare June 5, 2026 09:48
@blktests-ci

blktests-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown
Author

Upstream branch: ddd664b
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from 41a85d9 to 1088930 Compare June 5, 2026 10:19
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 7bed9c3 to a7bb5c5 Compare June 7, 2026 14:54
@blktests-ci

blktests-ci Bot commented Jun 7, 2026

Copy link
Copy Markdown
Author

Upstream branch: 979c294
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from 1088930 to 0bb3307 Compare June 7, 2026 15:28
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from a7bb5c5 to 5e41a3b Compare June 10, 2026 13:31
@blktests-ci

blktests-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown
Author

Upstream branch: acb7500
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from 0bb3307 to 8097531 Compare June 10, 2026 14:14
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 5e41a3b to c3a084b Compare June 10, 2026 20:26
@blktests-ci

blktests-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Author

Upstream branch: 9716c08
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from 8097531 to fd85eb5 Compare June 11, 2026 09:46
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from c3a084b to 5f78e5d Compare June 12, 2026 22:27
@blktests-ci

blktests-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Author

Upstream branch: 2a2974b
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from fd85eb5 to aa40e26 Compare June 12, 2026 23:11
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 5f78e5d to e48f9db Compare June 13, 2026 01:19
@blktests-ci

blktests-ci Bot commented Jun 13, 2026

Copy link
Copy Markdown
Author

Upstream branch: 062871f
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from aa40e26 to 7ada742 Compare June 13, 2026 02:08
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch 2 times, most recently from 199644a to e6d9eb8 Compare June 17, 2026 12:02
@blktests-ci

blktests-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 66affa3
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from 7ada742 to 3b4f364 Compare June 17, 2026 15:17
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from e6d9eb8 to 7d8604f Compare June 24, 2026 01:11
@guixinliu1995
block: rename need_dispatch to cautious_dispatch in blk-mq sched
b25c605 
The local boolean in __blk_mq_sched_dispatch_requests() decides whether
to fall back to the per-ctx round-robin path (blk_mq_do_dispatch_ctx())
instead of the batch flush path (blk_mq_flush_busy_ctxs()).  The whole
function is about dispatching anyway, so the name "need_dispatch" is
not particularly informative and can mislead readers into thinking that
a false value means "skip dispatching".

Rename it to "cautious_dispatch" to match the comment right above the
check ("dequeue request one by one from sw queue if queue is busy")
and to convey the actual intent: take the cautious, fair, one-at-a-time
path either when we just drained hctx->dispatch (so the device has
recently pushed back) or when the dispatch_busy EWMA still indicates
congestion.  The fast batch path is only taken when neither signal
suggests recent backpressure.

No functional change.

Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
@blktests-ci

blktests-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Author

Upstream branch: bade58e
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100976
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100976=>linus-master branch from 3b4f364 to b25c605 Compare June 24, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

linus-master new V1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@guixinliu1995