Skip to content

block: blk-mq: fix ws_active refcount leak in blk_mq_mark_tag_wait()#885

Open
blktests-ci[bot] wants to merge 1 commit into
linus-master_basefrom
series/1100862=>linus-master
Open

block: blk-mq: fix ws_active refcount leak in blk_mq_mark_tag_wait()#885
blktests-ci[bot] wants to merge 1 commit into
linus-master_basefrom
series/1100862=>linus-master

Conversation

@blktests-ci

@blktests-ci blktests-ci Bot commented May 26, 2026

Copy link
Copy Markdown

Pull request for series with
subject: block: blk-mq: fix ws_active refcount leak in blk_mq_mark_tag_wait()
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1100862

@blktests-ci

blktests-ci Bot commented May 26, 2026

Copy link
Copy Markdown
Author

Upstream branch: eed108e
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from de94ac7 to 86d8d37 Compare May 26, 2026 15:37
@blktests-ci

blktests-ci Bot commented May 26, 2026

Copy link
Copy Markdown
Author

Upstream branch: e8c2f9f
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from 38d9d03 to bce11b3 Compare May 26, 2026 15:57
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 86d8d37 to 9805659 Compare May 28, 2026 13:24
@blktests-ci

blktests-ci Bot commented May 28, 2026

Copy link
Copy Markdown
Author

Upstream branch: eb3f4b7
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from bce11b3 to 2570951 Compare May 28, 2026 13:44
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 9805659 to 3f4a345 Compare May 29, 2026 11:12
@blktests-ci

blktests-ci Bot commented May 29, 2026

Copy link
Copy Markdown
Author

Upstream branch: 8fde5d1
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from 2570951 to a300154 Compare May 29, 2026 11:31
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 3f4a345 to c6dc343 Compare June 1, 2026 08:57
@blktests-ci

blktests-ci Bot commented Jun 1, 2026

Copy link
Copy Markdown
Author

Upstream branch: e43ffb6
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from a300154 to fe088a8 Compare June 1, 2026 09:17
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from c6dc343 to fc36596 Compare June 3, 2026 13:56
@blktests-ci

blktests-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Author

Upstream branch: ba3e43a
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

1 similar comment
@blktests-ci

blktests-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Author

Upstream branch: ba3e43a
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from fe088a8 to 72cc08a Compare June 3, 2026 15:03
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from fc36596 to 7bed9c3 Compare June 5, 2026 09:48
@blktests-ci

blktests-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown
Author

Upstream branch: ddd664b
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from 72cc08a to 244d8bf Compare June 5, 2026 10:20
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 7bed9c3 to a7bb5c5 Compare June 7, 2026 14:54
@blktests-ci

blktests-ci Bot commented Jun 7, 2026

Copy link
Copy Markdown
Author

Upstream branch: 979c294
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from 244d8bf to dbda4e2 Compare June 7, 2026 15:29
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from a7bb5c5 to 5e41a3b Compare June 10, 2026 13:31
@blktests-ci

blktests-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown
Author

Upstream branch: acb7500
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from dbda4e2 to 7de30ea Compare June 10, 2026 14:15
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 5e41a3b to c3a084b Compare June 10, 2026 20:26
@blktests-ci

blktests-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Author

Upstream branch: 9716c08
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from 7de30ea to 3f065ad Compare June 11, 2026 09:46
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from c3a084b to 5f78e5d Compare June 12, 2026 22:27
@blktests-ci

blktests-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Author

Upstream branch: 2a2974b
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from 3f065ad to a1a3364 Compare June 12, 2026 23:12
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 5f78e5d to e48f9db Compare June 13, 2026 01:19
@blktests-ci

blktests-ci Bot commented Jun 13, 2026

Copy link
Copy Markdown
Author

Upstream branch: 062871f
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from a1a3364 to f7272cf Compare June 13, 2026 02:09
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch 2 times, most recently from 199644a to e6d9eb8 Compare June 17, 2026 12:02
@blktests-ci

blktests-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 66affa3
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from f7272cf to c3ac579 Compare June 17, 2026 15:19
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from e6d9eb8 to 7d8604f Compare June 24, 2026 01:11
@ISCAS-Vulab
block: blk-mq: fix ws_active refcount leak in blk_mq_mark_tag_wait()
4482771 
blk_mq_mark_tag_wait() calls sbitmap_queue_get() which increments
sbq->ws_active. On the error path where the waitqueue_active() check
fails and the function returns early, sbq->ws_active is not decremented,
leaking the reference.

Fix this by calling sbitmap_queue_clear() to properly release the
ws_active reference before returning on the error path.

Fixes: c27d53f ("blk-mq: Reduce the number of if-statements in blk_mq_mark_tag_wait()")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
@blktests-ci

blktests-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Author

Upstream branch: bade58e
series: https://patchwork.kernel.org/project/linux-block/list/?series=1100862
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1100862=>linus-master branch from c3ac579 to 4482771 Compare June 24, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

linus-master new V1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ISCAS-Vulab