nvme/059: fix unset bytes_to_write in TEST 7#245
Merged
Conversation
bytes_to_write was never assigned, causing TEST 7 to pass for the wrong reason. Set it to atomic_unit_max_bytes + logical_block_size and update the golden output with the expected "pwrite: Invalid argument" from xfs_io. Signed-off-by: Sebastian Chlad <sebastian.chlad@suse.com>
Collaborator
|
@schlad Good catch, thanks! The commit looks good to me. Actually, I found similar mistake exists in scsi/009 TEST 8 also. If you can create another PR or post patch for scsi/009, it will be a big help. (If you do not have time for it, that's okay, just let me know.) @alanpeterad FYI. If you have any comment, please share. |
Contributor
Author
I will take a look at the scsi/009 today afternoon (European time zone here). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bytes_to_write was never assigned, causing TEST 7 to pass for the wrong reason. Set it to atomic_unit_max_bytes + logical_block_size and update the golden output with the expected "pwrite: Invalid argument" from xfs_io.