Skip to content

Add long option to apfs-label & apfs-snap#17

Open
Integral-Tech wants to merge 2 commits into
linux-apfs:masterfrom
Integral-Tech:add-long-option
Open

Add long option to apfs-label & apfs-snap#17
Integral-Tech wants to merge 2 commits into
linux-apfs:masterfrom
Integral-Tech:add-long-option

Conversation

@Integral-Tech

Copy link
Copy Markdown
Contributor

No description provided.

@eafer

eafer commented Oct 23, 2024

Copy link
Copy Markdown
Member

Hi, I already saw your pull requests a while ago, it's just that I'm doing a lot of work on apfsprogs locally and I don't want to make a mess. I'll probably look into it in a few days.

@Integral-Tech

Copy link
Copy Markdown
Contributor Author

Hi, I already saw your pull requests a while ago, it's just that I'm doing a lot of work on apfsprogs locally and I don't want to make a mess. I'll probably look into it in a few days.

Okay, thanks :)

@eafer

eafer commented Nov 4, 2024

Copy link
Copy Markdown
Member

Do you need this to support long options for a particular reason?

@Integral-Tech

Integral-Tech commented Nov 4, 2024

Copy link
Copy Markdown
Contributor Author

Do you need this to support long options for a particular reason?

Just because most of Linux commands, including file system user utilities, support --version argument.

@eafer

eafer commented Nov 4, 2024

Copy link
Copy Markdown
Member

I just checked and the mkfs tools for ext4 and xfs don't have a long --version. In fact they don't use -v, they use -V heh. I think it's better to leave it as it is, I don't know if there are portability issues with getopt_long.

@Integral-Tech

Integral-Tech commented Nov 5, 2024

Copy link
Copy Markdown
Contributor Author

I just checked and the mkfs tools for ext4 and xfs don't have a long --version. In fact they don't use -v, they use -V heh. I think it's better to leave it as it is, I don't know if there are portability issues with getopt_long.

Btrfs tool has --version option:

╰─❯ btrfs --version
btrfs-progs v6.11
-EXPERIMENTAL -INJECT -STATIC +LZO +ZSTD +UDEV +FSVERITY +ZONED CRYPTO=libgcrypt

@eafer

eafer commented Nov 5, 2024

Copy link
Copy Markdown
Member

Sure, I know that plenty of other tools have --version. I just meant that it's not universal, so it's not a problem if it's missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants