Skip to content

Add Sunxi SID read support - #1

Open
karthi012 wants to merge 1 commit into
masterfrom
upstream/a133-sid
Open

Add Sunxi SID read support#1
karthi012 wants to merge 1 commit into
masterfrom
upstream/a133-sid

Conversation

@karthi012

Copy link
Copy Markdown

Add supprt for allwinner sunxi sid registers read. Driver is tested on the A133 platform. For more information about the sunxi SID regiters see https://linux-sunxi.org/SID_Register_Guide

@karthi012

Copy link
Copy Markdown
Author

@ssekar15 @parthitce Request for review.

@github-actions

Copy link
Copy Markdown

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions Bot added the Stale label Jul 16, 2026

@parthitce parthitce left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine to submit upstream

Comment thread core/drivers/sunxi_sid.c
int tee_otp_get_die_id(uint8_t *buffer, size_t len)
{
if (!buffer || len != SUNXI_SID_CHIPID_LEN)
return -1;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no specific errorno?

Comment thread core/drivers/sunxi_sid.c
return -1;

if (sunxi_sid_read_otp(buffer, len, SUNXI_SID_CHIP_ID_REG))
return -1;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Add a driver for the Allwinner Security ID (SID) efuse block, based
on the register layout described in [1] and tested on the A133 SoC.
A133 uses same SID layout as the H6 generation described there.
Currently the driver only implements reading and is used for the
chip ID and the HUK from efuse register.

Note that the SID, including the HUK area, is readable from the
normal world unless the secure boot fuse is burnt. The HUK is
therefore only secret on devices with secure boot enabled.

[1]: https://linux-sunxi.org/SID_Register_Guide

Signed-off-by: Karthikeyan Kalamani <karthikeyan@linumiz.com>
Reviewed-by: Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@oss.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants