ci: set repo context for the release PR merge - #28
Merged
Conversation
The Release Please workflow never checks out the repo, so gh pr merge fails with 'not a git repository'. Set GH_REPO so gh targets the repo via the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The merge step fails on every run:
This workflow never runs
actions/checkout(release-please works via the API), sogh pr merge <number>has no git context to resolve the repo from.Fix
Set
GH_REPO: ${{ github.repository }}in the step env soghtargets the repo explicitly.Also: why the previous CI fix triggered a release
The prior hotfix was typed
fix(ci):— release-please bumps on thefixtype (scope is irrelevant), so it opened a pointless patch release PR. This PR is typedci:, which release-please ignores for versioning. Going forward, CI-only changes should use theci:type, notfix(ci):.