Skip to content

fix(ci): parse release PR number in shell, not fromJSON in env #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jflayhart merged 1 commit into from
Jun 10, 2026
Merged

fix(ci): parse release PR number in shell, not fromJSON in env #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,9 @@ jobs:
if: ${{ steps.release.outputs.pr }}
env:
GH_TOKEN: ${{ secrets.RELEASE_PLEASE_TOKEN }}
PR_NUMBER: ${{ fromJSON(steps.release.outputs.pr).number }}
run: gh pr merge "$PR_NUMBER" --squash
# Pass the raw output through and parse it in the shell. Do NOT call
# fromJSON() here: on runs where release-please cuts the release there
# is no open PR, `pr` is empty, and fromJSON('') fails the whole
# workflow with a template error even though `if` skips the step.
RELEASE_PR: ${{ steps.release.outputs.pr }}
run: gh pr merge "$(jq -r '.number' <<< "$RELEASE_PR")" --squash
Loading