fix: restore message + phone IDs in list output, clarify direction - #31
Merged
Conversation
Collaborator
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v2 rewrite dropped the ID column from
linq messages listandlinq phonenumbers— so an agent (or a human) can't grab an ID to act on a specific message or phone without falling back to--json.messages listwas also confusing:→ +1 (205) 222-2918) was ambiguous — does it mean "sent to" or "sent from"?sent / delivered / readstatus was shown for every row, but "sent" is meaningless for an inbound message.messages list --jsonwas leaking the raw SDK envelope (options,response, a duplicated payload) — noisy and coupled to SDK internals.Solution
messages list: bring back the message ID (cyan, leftmost, copy-paste ready); switch to absolute timestamps; drop the status column (still inlinq messages get); replace the ambiguous arrow with explicityou → +1 (...)/+1 (...) → you.phonenumbers: bring back the phone number's UUID before the formatted phone.messages list --json: emit just{ messages, next_cursor }instead of the whole SDK wrapper.Notes
Other commands still leak the SDK envelope in
--json. Follow-up PR will clean those up uniformly.